Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unsafe from 'query_selector_iter' #8095

Merged
merged 1 commit into from Oct 20, 2015
Merged

Removed unsafe from 'query_selector_iter' #8095

merged 1 commit into from Oct 20, 2015

Conversation

@TileHalo
Copy link
Contributor

TileHalo commented Oct 20, 2015

Fixing #8078.

Review on Reviewable
@highfive
Copy link

highfive commented Oct 20, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon.
@TileHalo
Removed unsafe from 'query_selector_iter'
Loading status checks…
89e8a26
@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 20, 2015

Thank you for your PR.

@bors-servo r+
-S-awaiting-review +S-awaiting-merge

Reviewed 3 of 3 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2015

📌 Commit 89e8a26 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2015

⌛ Testing commit 89e8a26 with merge 25d3c2b...
bors-servo pushed a commit that referenced this pull request Oct 20, 2015
bors-servo
Auto merge of #8095 - TileHalo:foo, r=Ms2ger
Loading status checks…
25d3c2b 
Removed unsafe from 'query_selector_iter'

Fixing #8078.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8095)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2015

💔 Test failed - mac-rel-wpt
@nox
Copy link
Member

nox commented Oct 20, 2015

@bors-servo retry #7787
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2015

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 89e8a26 into servo:master Oct 20, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Oct 20, 2015
Merged
@nox nox mentioned this pull request Oct 20, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@TileHalo @highfive @Ms2ger @bors-servo @nox @SimonSapin
You can’t perform that action at this time.