Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit lifetimes which can be elided #8099

Merged
merged 1 commit into from Oct 21, 2015
Merged

Remove explicit lifetimes which can be elided #8099

merged 1 commit into from Oct 21, 2015

Conversation

@AdamSzopa
Copy link

AdamSzopa commented Oct 20, 2015

Fixes #8069

Review on Reviewable
@highfive
Copy link

highfive commented Oct 20, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @glennw (or someone else) soon.
@highfive
Copy link

highfive commented Oct 20, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
@mbrubeck mbrubeck self-assigned this Oct 20, 2015
@mbrubeck
Copy link
Contributor

mbrubeck commented Oct 20, 2015

This looks great, thanks! Could you rebase these commits onto master, then force push them? Then they can land with r=mbrubeck.
Adam Szopa
Remove explicit lifetimes which can be elided.
Loading status checks…
8899101
@AdamSzopa AdamSzopa force-pushed the AdamSzopa:master branch from e1dd45f to 8899101 Oct 20, 2015
@mbrubeck
Copy link
Contributor

mbrubeck commented Oct 20, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2015

📌 Commit 8899101 has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2015

⌛ Testing commit 8899101 with merge 941c06e...
bors-servo pushed a commit that referenced this pull request Oct 20, 2015
bors-servo
Auto merge of #8099 - Darktori:master, r=mbrubeck
Loading status checks…
941c06e 
Remove explicit lifetimes which can be elided

Fixes #8069

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8099)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2015

💔 Test failed - mac-dev-ref-unit
@mbrubeck
Copy link
Contributor

mbrubeck commented Oct 20, 2015

@bors-servo retry

#7785
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2015

⚡ Previous build results for android, gonk, linux-dev are reusable. Rebuilding only linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 21, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 8899101 into servo:master Oct 21, 2015
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@AdamSzopa @highfive @mbrubeck @bors-servo @SimonSapin
You can’t perform that action at this time.