Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make button elements activatable. #8109

Merged
merged 1 commit into from Dec 29, 2015
Merged

Make button elements activatable. #8109

merged 1 commit into from Dec 29, 2015

Conversation

@jdm
Copy link
Member

jdm commented Oct 21, 2015

Review on Reviewable
@jdm jdm force-pushed the jdm:buttonactivate branch from b5dda63 to d5069e2 Oct 21, 2015
@frewsxcv
Copy link
Member

frewsxcv commented Oct 21, 2015

Regression test?
@jdm
Copy link
Member Author

jdm commented Oct 21, 2015

I'll see if form.submit() could catch this.
@frewsxcv
Copy link
Member

frewsxcv commented Oct 21, 2015

Also, according to travis, there are build issues
@jdm
Copy link
Member Author

jdm commented Oct 21, 2015

I have a WPT test which is waiting on a fix for #8113.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 21, 2015

☔ The latest upstream changes (presumably #8041) made this pull request unmergeable. Please resolve the merge conflicts.
@eefriedman eefriedman self-assigned this Nov 3, 2015
@frewsxcv
Copy link
Member

frewsxcv commented Dec 7, 2015

#8113 has been resolved
@jdm jdm force-pushed the jdm:buttonactivate branch from d5069e2 to 4e67397 Dec 7, 2015
@jdm
Copy link
Member Author

jdm commented Dec 7, 2015

Updated!
@frewsxcv
Copy link
Member

frewsxcv commented Dec 7, 2015

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2015

⌛ Trying commit 4e67397 with merge feca532...
bors-servo added a commit that referenced this pull request Dec 7, 2015
@bors-servo
Auto merge of #8109 - jdm:buttonactivate, r=<try>
feca532 
Make button elements activatable.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8109)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2015

💔 Test failed - linux-dev
@eefriedman
Copy link
Contributor

eefriedman commented Dec 8, 2015 

  ▶ OK [expected TIMEOUT] /DOMEvents/tests/approved/dispatchEvent.click.checkbox.html

  ▶ Unexpected subtest result in /DOMEvents/tests/approved/dispatchEvent.click.checkbox.html:
  │ FAIL [expected PASS] Test Description: MouseEvent: Default action is performed when a synthetic click event is dispatched on a checkbox element
  │   → assert_array_equals: property 0, expected true but got false
  │ 
  │ TestEvent/<@http://web-platform.test:8000/DOMEvents/tests/approved/dispatchEvent.click.checkbox.html:55:17
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1381:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  │ TestEvent@http://web-platform.test:8000/DOMEvents/tests/approved/dispatchEvent.click.checkbox.html:53:1
  │ TestEvent@http://web-platform.test:8000/DOMEvents/tests/approved/dispatchEvent.click.checkbox.html:49:13
  └ window.onload@http://web-platform.test:8000/DOMEvents/tests/approved/dispatchEvent.click.checkbox.html:16:9

  ▶ OK [expected TIMEOUT] /DOMEvents/tests/submissions/Microsoft/converted/dispatchEvent.click.checkbox.html

  ▶ Unexpected subtest result in /DOMEvents/tests/submissions/Microsoft/converted/dispatchEvent.click.checkbox.html:
  │ FAIL [expected PASS] Test Description: MouseEvent: Default action is performed when a synthetic click event is dispatched on a checkbox element
  │   → assert_array_equals: property 0, expected true but got false
  │ 
  │ TestEvent/<@http://web-platform.test:8000/DOMEvents/tests/submissions/Microsoft/converted/dispatchEvent.click.checkbox.html:55:17
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1381:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  │ TestEvent@http://web-platform.test:8000/DOMEvents/tests/submissions/Microsoft/converted/dispatchEvent.click.checkbox.html:53:1
  │ TestEvent@http://web-platform.test:8000/DOMEvents/tests/submissions/Microsoft/converted/dispatchEvent.click.checkbox.html:49:13
  └ window.onload@http://web-platform.test:8000/DOMEvents/tests/submissions/Microsoft/converted/dispatchEvent.click.checkbox.html:16:9

  ▶ CRASH [expected TIMEOUT] /html/semantics/forms/the-button-element/button-events.html
  │ 
  │ thread 'LayoutTask PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(100) }' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 35, message: "Resource temporarily unavailable" } }', ../src/libcore/result.rs:741
  │ stack backtrace:
  │    1:        0x103141e08 - sys::backtrace::tracing::imp::write::h7d2881098672eadd7It
  │    2:        0x103143f4f - panicking::log_panic::_<closure>::closure.40649
  │    3:        0x1031439f2 - panicking::log_panic::h8037c21ca8707493MAx
  │    4:        0x10312eee6 - sys_common::unwind::begin_unwind_inner::h87d033c2dbe04bc77Ls
  │    5:        0x10312f2ce - sys_common::unwind::begin_unwind_fmt::h086b7999edf0c62fdLs
  │    6:        0x103141427 - rust_begin_unwind
  │    7:        0x103166530 - panicking::panic_fmt::h761c3d51c4df5175ZFK
  │    8:        0x101f2e335 - result::_<impl>::unwrap::unwrap::h17986274935423628741
  │    9:        0x101f4f0bf - workqueue::_<impl>::new::new::h6179496024418368859
  │   10:        0x101f30f5b - layout_task::_<impl>::new::h0d0f44fbe7e7b5617oq
  │   11:        0x101f2ea0b - sys_common::unwind::try::try_fn::try_fn::h2827801216446258168
  │   12:        0x103141248 - __rust_try
  │   13:        0x10313e34e - sys_common::unwind::try::inner_try::hdd63401dff52b04dFIs
  │   14:        0x101f2fd1a - boxed::_<impl>::call_box::call_box::h12730511991798588194
  │   15:        0x1031431dd - sys::thread::_<impl>::new::thread_start::h146dc2a2095e243ajVw
  │   16:     0x7fff84ed8059 - _pthread_body
  │   17:     0x7fff84ed7fd6 - _pthread_start
  │ thread 'thread 'LayoutWorker worker 1/6' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', ../src/libcore/result.rs:741
  │ stack backtrace:
  │ thread 'LayoutWorker worker 3/6' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', ../src/libcore/result.rs:741
  │ LayoutWorker worker 2/6' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', ../src/libcore/result.rs:741
  │ thread 'PaintTask PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(100) }' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', ../src/libcore/result.rs:741
  │ thread 'LayoutWorker worker 4/6' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', ../src/libcore/result.rs:741
  │    1:        0x103141e08 - sys::backtrace::tracing::imp::write::h7d2881098672eadd7It
  │ Pipeline failed in hard-fail mode.  Crashing!
  │    2:        0x103143f4f - panicking::log_panic::_<closure>::closure.40649
  │    3:        0x1031439f2 - panicking::log_panic::h8037c21ca8707493MAx
  │    4:        0x10312eee6 - sys_common::unwind::begin_unwind_inner::h87d033c2dbe04bc77Ls
  │    5:        0x10312f2ce - sys_common::unwind::begin_unwind_fmt::h086b7999edf0c62fdLs
  └    6:        0x103141427 - rust_begin_unwind

  ▶ Unexpected subtest result in /html/webappapis/scripting/events/event-handler-spec-example.html:
  └ PASS [expected FAIL] Event handler listeners should be registered when they are first set to an object value (object "[object Object]").

  ▶ Unexpected subtest result in /html/webappapis/scripting/events/event-handler-spec-example.html:
  └ PASS [expected FAIL] Event handler listeners should be registered when they are first set to an object value (function "function () {}").

  ▶ Unexpected subtest result in /html/webappapis/scripting/events/event-handler-spec-example.html:
  └ PASS [expected FAIL] Event handler listeners should be registered when they are first set to an object value (object "42").

  ▶ Unexpected subtest result in /html/webappapis/scripting/events/event-handler-spec-example.html:
  └ PASS [expected FAIL] Event handler listeners should be registered when they are first set to an object value (object "").

  ▶ Unexpected subtest result in /html/webappapis/scripting/events/event-handler-spec-example.html:
  └ PASS [expected FAIL] Event handler listeners should be registered when they are first set to an object value (42).

  ▶ Unexpected subtest result in /html/webappapis/scripting/events/event-handler-spec-example.html:
  └ PASS [expected FAIL] Event handler listeners should be registered when they are first set to an object value (null).

  ▶ Unexpected subtest result in /html/webappapis/scripting/events/event-handler-spec-example.html:
  └ PASS [expected FAIL] Event handler listeners should be registered when they are first set to an object value (undefined).

  ▶ Unexpected subtest result in /html/webappapis/scripting/events/event-handler-spec-example.html:
  └ PASS [expected FAIL] Event handler listeners should be registered when they are first set to an object value ("").

  ▶ Unexpected subtest result in /html/webappapis/scripting/events/event-handler-spec-example.html:
  └ PASS [expected FAIL] Event handler listeners should be registered when they are first set to an object value.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2015

☔ The latest upstream changes (presumably #8915) made this pull request unmergeable. Please resolve the merge conflicts.
@jdm jdm removed the S-awaiting-review label Dec 10, 2015
@jdm
Make button elements activatable. Fixes #4837. Fixes #8101.
Loading status checks…
7693b03
@jdm jdm force-pushed the jdm:buttonactivate branch from 4e67397 to 7693b03 Dec 29, 2015
@jdm jdm removed the S-needs-rebase label Dec 29, 2015
@jdm
Copy link
Member Author

jdm commented Dec 29, 2015

All previously encountered test result changes are now updated accordingly.
@eefriedman
Copy link
Contributor

eefriedman commented Dec 29, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 29, 2015

📌 Commit 7693b03 has been approved by eefriedman
@bors-servo
Copy link
Contributor

bors-servo commented Dec 29, 2015

⌛ Testing commit 7693b03 with merge 4a8e22c...
bors-servo added a commit that referenced this pull request Dec 29, 2015
@bors-servo
Auto merge of #8109 - jdm:buttonactivate, r=eefriedman
Loading status checks…
4a8e22c 
Make button elements activatable.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8109)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 29, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 7693b03 into servo:master Dec 29, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Dec 29, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eefriedman eefriedman

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @frewsxcv @bors-servo @eefriedman @highfive
You can’t perform that action at this time.