Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't require the CanvasFillOrStrokeStyle enum to be public #8115
Conversation
|
@bors-servo: r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Oct 21, 2015
Don't require the CanvasFillOrStrokeStyle enum to be public CanvasFillOrStrokeStyle is only used in a single file, so it does not need to be a public enum. Fixes #8105. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8115) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
bors-servo
pushed a commit
that referenced
this pull request
Oct 21, 2015
Don't require the CanvasFillOrStrokeStyle enum to be public CanvasFillOrStrokeStyle is only used in a single file, so it does not need to be a public enum. Fixes #8105. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8115) <!-- Reviewable:end -->
|
|
This was referenced Oct 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nerith commentedOct 21, 2015
CanvasFillOrStrokeStyle is only used in a single file,
so it does not need to be a public enum.
Fixes #8105.