Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement cancellable runnables, and make image load events cancellab… #8138
Conversation
|
r? @nox |
|
Seems good; just one nit and question. If you could rewrite the commit message to a short title and a body it would be perfect. -S-awaiting-review +S-needs-code-changes Reviewed 4 of 4 files at r1. components/script/dom/window.rs, line 69 [r1] (raw file): components/script/script_task.rs, line 170 [r1] (raw file): Comments from the review on Reviewable.io |
|
Review status: 1 of 4 files reviewed at latest revision, 2 unresolved discussions, all commit checks successful. components/script/script_task.rs, line 170 [r1] (raw file): Comments from the review on Reviewable.io |
|
|
|
Nit fixed. Let's kill off an annoying intermittent test failure! |
|
@bors-servo r=nox |
|
|
Implement cancellable runnables, and make image load events cancellab… …le. Resolves #7731. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8138) <!-- Reviewable:end -->
|
|
jdm commentedOct 21, 2015
…le. Resolves #7731.