Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: Element.webkitMatchesSelector() #8183

Merged
merged 1 commit into from Oct 25, 2015
Merged

script: Element.webkitMatchesSelector() #8183

merged 1 commit into from Oct 25, 2015

Conversation

@tetsuharuohzeki
Copy link
Member

tetsuharuohzeki commented Oct 25, 2015

spec:

Review on Reviewable
@tetsuharuohzeki
script: Element.webkitMatchesSelector()
Loading status checks…
04967ed 
spec:
whatwg/dom@9ac9c15
@tetsuharuohzeki
Copy link
Member Author

tetsuharuohzeki commented Oct 25, 2015

@Ms2ger r?
@nox nox mentioned this pull request Oct 25, 2015
Open
@nox
Copy link
Member

nox commented Oct 25, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 25, 2015

📌 Commit 04967ed has been approved by nox
@nox nox self-assigned this Oct 25, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Oct 25, 2015

⌛ Testing commit 04967ed with merge 47a8256...
bors-servo added a commit that referenced this pull request Oct 25, 2015
@bors-servo
Auto merge of #8183 - saneyuki:matches, r=nox
Loading status checks…
47a8256 
script: Element.webkitMatchesSelector()

spec:
- whatwg/dom@9ac9c15
  - whatwg/compat#3

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8183)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 25, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 04967ed into servo:master Oct 25, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 25, 2015

I'm not too happy about this landing without tests, but I'll let it pass because I already submitted tests upstream.
@tetsuharuohzeki tetsuharuohzeki deleted the tetsuharuohzeki:matches branch Oct 25, 2015
@tetsuharuohzeki
Copy link
Member Author

tetsuharuohzeki commented Oct 25, 2015

@Ms2ger

Sorry, I was going to ask you about tests and we should wait to merge the test which you submitted. I should have written the comment about it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
A-content/dom S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@tetsuharuohzeki @nox @bors-servo @Ms2ger @highfive
You can’t perform that action at this time.