Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a Layoutnode::new function and use it. #8187

Merged
merged 5 commits into from Oct 30, 2015
Merged

Introduce a Layoutnode::new function and use it. #8187

merged 5 commits into from Oct 30, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 25, 2015

Review on Reviewable
@highfive
Copy link

highfive commented Oct 25, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Oct 25, 2015

Open question: should it be unsafe? I guess a TrustedNodeAddress could get stored away somewhere.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 26, 2015

☔ The latest upstream changes (presumably #8205) made this pull request unmergeable. Please resolve the merge conflicts.
@Ms2ger Ms2ger force-pushed the Ms2ger:layoutnode-new branch from aaa81c3 to 06514f7 Oct 26, 2015
@Ms2ger Ms2ger removed the S-needs-rebase label Oct 26, 2015
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Oct 27, 2015

r? @pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Oct 28, 2015

☔ The latest upstream changes (presumably #8098) made this pull request unmergeable. Please resolve the merge conflicts.
Ms2ger added 5 commits Oct 25, 2015
@Ms2ger
Privatize LayoutNode::chain.
244bd11 
There is no reason for this field to be public.
@Ms2ger
Implement a LayoutNode::new function.
06f9a2b
@Ms2ger
Pass a LayoutNode to LayoutTask::dirty_all_nodes.
ee0b0c8 
There is no point in passing a mutable reference to what is essentially
already a pointer.
@Ms2ger
Simplify LayoutDocument::root_node.
1eb8900
@Ms2ger
Use LayoutNode::new to avoid transmute calls in LayoutTask.
Loading status checks…
cce5109
@Ms2ger Ms2ger force-pushed the Ms2ger:layoutnode-new branch from 06514f7 to cce5109 Oct 29, 2015
@pcwalton
Copy link
Contributor

pcwalton commented Oct 29, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2015

📌 Commit cce5109 has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2015

⌛ Testing commit cce5109 with merge aeb4e0e...
bors-servo added a commit that referenced this pull request Oct 29, 2015
@bors-servo
Auto merge of #8187 - Ms2ger:layoutnode-new, r=pcwalton
aeb4e0e 
Introduce a Layoutnode::new function and use it.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8187)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2015

💔 Test failed - mac-dev-ref-unit
@eefriedman
Copy link
Contributor

eefriedman commented Oct 29, 2015

@bors-servo retry #7785.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2015

⌛ Testing commit cce5109 with merge 6776d23...
bors-servo added a commit that referenced this pull request Oct 29, 2015
@bors-servo
Auto merge of #8187 - Ms2ger:layoutnode-new, r=pcwalton
6776d23 
Introduce a Layoutnode::new function and use it.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8187)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2015

💔 Test failed - mac-dev-ref-unit
@eefriedman
Copy link
Contributor

eefriedman commented Oct 30, 2015

@bors-servo retry
@eefriedman
Copy link
Contributor

eefriedman commented Oct 30, 2015

(#7785 again.)
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

⌛ Testing commit cce5109 with merge 70f17be...
bors-servo added a commit that referenced this pull request Oct 30, 2015
@bors-servo
Auto merge of #8187 - Ms2ger:layoutnode-new, r=pcwalton
70f17be 
Introduce a Layoutnode::new function and use it.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8187)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

💔 Test failed - mac-rel-wpt
@eefriedman
Copy link
Contributor

eefriedman commented Oct 30, 2015

@bors-servo retry #7731
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

⌛ Testing commit cce5109 with merge 6cc8186...
bors-servo added a commit that referenced this pull request Oct 30, 2015
@bors-servo
Auto merge of #8187 - Ms2ger:layoutnode-new, r=pcwalton
Loading status checks…
6cc8186 
Introduce a Layoutnode::new function and use it.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8187)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit cce5109 into servo:master Oct 30, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Oct 30, 2015
Merged
@Ms2ger Ms2ger deleted the Ms2ger:layoutnode-new branch Oct 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @bors-servo @pcwalton @eefriedman
You can’t perform that action at this time.