Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust #821

Closed
wants to merge 8 commits into from
Closed

Update Rust #821

wants to merge 8 commits into from

Conversation

@brson
Copy link
Contributor

brson commented Aug 29, 2013

brson added 3 commits Aug 28, 2013
Conflicts:
	src/components/script/dom/bindings/proxyhandler.rs
	src/components/script/dom/bindings/text.rs
@jdm

This comment has been minimized.

Copy link

jdm commented on 1026556 Aug 30, 2013

This can be merged as soon as the prerequisites are ready; it looks fine to me.

@brson
Copy link
Contributor Author

brson commented Aug 30, 2013

Sorry for the ugly commit history here.

@metajack

This comment has been minimized.

Copy link

metajack commented on 6d52445 Aug 30, 2013

r+

This comment has been minimized.

Copy link

metajack replied Aug 30, 2013

@bors: retry

This comment has been minimized.

Copy link

metajack replied Aug 30, 2013

@bors: retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 6d52445 Aug 30, 2013

saw approval from metajack
at brson@6d52445

This comment has been minimized.

Copy link
Contributor

bors-servo replied Aug 30, 2013

merging brson/servo/master = 6d52445 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Aug 30, 2013

brson/servo/master = 6d52445 merged ok, testing candidate = f288478

This comment has been minimized.

Copy link
Contributor

bors-servo replied Aug 30, 2013

saw approval from metajack
at brson@6d52445

This comment has been minimized.

Copy link
Contributor

bors-servo replied Aug 30, 2013

merging brson/servo/master = 6d52445 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Aug 30, 2013

merging brson/servo/master = 6d52445 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Aug 30, 2013

brson/servo/master = 6d52445 merged ok, testing candidate = 660ede7

This comment has been minimized.

Copy link
Contributor

bors-servo replied Aug 30, 2013

This comment has been minimized.

Copy link
Contributor

bors-servo replied Aug 30, 2013

bors-servo pushed a commit that referenced this pull request Aug 30, 2013
bors-servo pushed a commit that referenced this pull request Aug 30, 2013
bors-servo pushed a commit that referenced this pull request Aug 30, 2013
@SimonSapin
Copy link
Member

SimonSapin commented Aug 30, 2013

@brson , I believe this is missing a change in src/compiler/rust-auto-clean-trigger. (I just built your PR and still had an older rust.)

@SimonSapin
Copy link
Member

SimonSapin commented Aug 30, 2013

brson added 2 commits Aug 30, 2013
Conflicts:
	src/components/script/dom/bindings/element.rs
	src/components/script/dom/bindings/node.rs
	src/components/script/dom/bindings/utils.rs
@brson

This comment has been minimized.

Copy link
Owner Author

brson commented on 4487b1c Aug 30, 2013

r=metajack

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 4487b1c Aug 30, 2013

saw approval from brson, metajack
at brson@4487b1c

This comment has been minimized.

Copy link
Contributor

bors-servo replied Aug 30, 2013

merging brson/servo/master = 4487b1c into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Aug 30, 2013

brson/servo/master = 4487b1c merged ok, testing candidate = 403d1d5

This comment has been minimized.

Copy link
Contributor

bors-servo replied Aug 30, 2013

@brson

This comment has been minimized.

Copy link
Owner Author

brson commented on e2aa7b8 Aug 30, 2013

r=metajack

This comment has been minimized.

Copy link

metajack replied Aug 30, 2013

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on e2aa7b8 Aug 30, 2013

saw approval from brson, metajack, metajack
at brson@e2aa7b8

This comment has been minimized.

Copy link
Contributor

bors-servo replied Aug 30, 2013

merging brson/servo/master = e2aa7b8 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Aug 30, 2013

brson/servo/master = e2aa7b8 merged ok, testing candidate = c532c73

This comment has been minimized.

Copy link
Contributor

bors-servo replied Aug 30, 2013

fast-forwarding master to auto = c532c73

@bors-servo bors-servo closed this Aug 30, 2013
ChrisParis pushed a commit to ChrisParis/servo that referenced this pull request Sep 7, 2014
Allow testharness properties to be set from the runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.