Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SharedLayoutContext::reflow_root. #8212

Merged
merged 2 commits into from Oct 30, 2015
Merged

Remove SharedLayoutContext::reflow_root. #8212

merged 2 commits into from Oct 30, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 26, 2015

Review on Reviewable
Ms2ger added 2 commits Jul 9, 2015
@Ms2ger
Use the passed-in reflow root rather than the one stored in the Share…
9f91984 
…dLayoutContext.
@Ms2ger
Remove the reflow root from SharedLayoutContext.
Loading status checks…
c693e13
@highfive
Copy link

highfive commented Oct 26, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Oct 26, 2015

r? @pcwalton
@pcwalton
Copy link
Contributor

pcwalton commented Oct 29, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2015

📌 Commit c693e13 has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2015

⌛ Testing commit c693e13 with merge 3524aba...
bors-servo added a commit that referenced this pull request Oct 29, 2015
@bors-servo
Auto merge of #8212 - Ms2ger:reflow-root, r=pcwalton
3524aba 
Remove SharedLayoutContext::reflow_root.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8212)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2015

💔 Test failed - mac-dev-ref-unit
@eefriedman
Copy link
Contributor

eefriedman commented Oct 29, 2015

@bors-servo retry #7785.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2015

⌛ Testing commit c693e13 with merge b6bcccb...
bors-servo added a commit that referenced this pull request Oct 29, 2015
@bors-servo
Auto merge of #8212 - Ms2ger:reflow-root, r=pcwalton
Loading status checks…
b6bcccb 
Remove SharedLayoutContext::reflow_root.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8212)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit c693e13 into servo:master Oct 30, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Oct 30, 2015
Closed
@Ms2ger Ms2ger deleted the Ms2ger:reflow-root branch Oct 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @pcwalton @bors-servo @eefriedman
You can’t perform that action at this time.