Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake executing synthesized pinch zoom more similar to zoom #8223
Conversation
|
This seems like a good solution to me, but I'm having a hard time understanding how the masking works, since it doesn't seem to actually check for the presence of Alt. |
|
@jdm The masking was trickier than I expected, but I think the latest version properly checks for Alt. |
|
@bors-servo: r+ |
|
|
Make executing synthesized pinch zoom more similar to zoom Synthesized pinch zoom was removed in #8121 so that this combination of mouse wheel and key press can be handled by the page. I mistakenly re-implemented it #8215. In order to preserve synthesized pinch zoom, which is very useful for testing on desktop computers, have it work similarly to page zoom except with the ALT key pressed. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8223) <!-- Reviewable:end -->
| } | ||
| (CMD_OR_CONTROL, Key::Minus) => { | ||
| self.event_queue.borrow_mut().push(WindowEvent::Zoom(1.0 / 1.1)); | ||
| } | ||
| (_control_and_alt, Key::Minus) => { |
This comment has been minimized.
This comment has been minimized.
mbrubeck
Oct 27, 2015
Contributor
This is incorrect; it's equivalent to a wildcard. It binds to a new variable named _control_and_alt rather than comparing to the existing one.
|
@bors-servo r- |
|
|
Synthesized pinch zoom was removed in #8121 so that this combination of mouse wheel and key press can be handled by the page. I mistakenly re-implemented it #8215. In order to preserve synthesized pinch zoom, which is very useful for testing on desktop computers, have it work similarly to page zoom except with the ALT key pressed.
|
I think the latest version fixes the issue. Thanks again, @mbrubeck, for catching that. |
|
@bors-servo: r+ |
|
|
Make executing synthesized pinch zoom more similar to zoom Synthesized pinch zoom was removed in #8121 so that this combination of mouse wheel and key press can be handled by the page. I mistakenly re-implemented it #8215. In order to preserve synthesized pinch zoom, which is very useful for testing on desktop computers, have it work similarly to page zoom except with the ALT key pressed. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8223) <!-- Reviewable:end -->
|
|
|
|
|
|
|
@bors-servo: retry |
Make executing synthesized pinch zoom more similar to zoom Synthesized pinch zoom was removed in #8121 so that this combination of mouse wheel and key press can be handled by the page. I mistakenly re-implemented it #8215. In order to preserve synthesized pinch zoom, which is very useful for testing on desktop computers, have it work similarly to page zoom except with the ALT key pressed. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8223) <!-- Reviewable:end -->
|
|
mrobinson commentedOct 27, 2015
Synthesized pinch zoom was removed in #8121 so that this combination of
mouse wheel and key press can be handled by the page. I mistakenly
re-implemented it #8215. In order to preserve synthesized pinch zoom,
which is very useful for testing on desktop computers, have it work
similarly to page zoom except with the ALT key pressed.