Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDisable debug logging in release builds #8229
Merged
Conversation
|
|
This uses the new `release_max_level` feature added in rust-lang/log#58 to turn the `debug!` and `trace!` macros into no-ops in optimized builds.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 28, 2015
Disable debug logging in release builds This uses the new `release_max_level` feature added in rust-lang/log#58 to turn the `debug!` and `trace!` macros into no-ops in optimized builds. r? @pcwalton (or anyone else who wants it) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8229) <!-- Reviewable:end -->
|
|
This was referenced Oct 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedOct 27, 2015
This uses the new
release_max_levelfeature added in rust-lang/log#58 to turn thedebug!andtrace!macros into no-ops in optimized builds.r? @pcwalton (or anyone else who wants it)