Correct event dispatching for multiple simultaneous touch points #8232

mbrubeck · 2015-10-28T00:36:47Z

Instead of just converting the mouse into a single "touch" input, Servo can now listen for multi-touch events from Glutin, maintain a list of active touch points, and dispatch events for all of them.

r? @glennw (for the compositor changes) and @jdm (for the DOM changes)

jdm · 2015-10-28T13:22:41Z

+S-needs-code-changes

Reviewed 3 of 7 files at r1, 1 of 1 files at r2.
Review status: 3 of 7 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

^{components/script/dom/document.rs, line 801 [r2] (raw file):}
*t.Target() == target

Comments from the review on Reviewable.io

mbrubeck · 2015-10-28T16:15:11Z

Review status: 2 of 7 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.

^{components/script/dom/document.rs, line 801 [r2] (raw file):}
How's this? It still uses Root for the comparison, but the code is cleaned up a bit...

An alternative we discussed on IRC would be to add a raw pointer comparison method that doesn't require Root.

Comments from the review on Reviewable.io

jdm · 2015-10-28T16:32:07Z

Reviewed 1 of 2 files at r3.
Review status: 3 of 7 files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from the review on Reviewable.io

bors-servo · 2015-10-28T22:14:29Z

☔ The latest upstream changes (presumably #8229) made this pull request unmergeable. Please resolve the merge conflicts.

glennw · 2015-11-01T23:36:41Z

Reviewed 2 of 7 files at r1.
Review status: 4 of 7 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

^{components/compositing/compositor.rs, line 84 [r1] (raw file):}
Can we add some comments describing what this u32 represents?

^{components/compositing/windowing.rs, line 64 [r1] (raw file):}
Should the i32 be a new type?

Comments from the review on Reviewable.io

mbrubeck · 2015-11-02T17:59:24Z

Rebased and addressed review comments.

Review status: 0 of 7 files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

glennw · 2015-11-02T20:27:42Z

Reviewed 2 of 7 files at r1, 1 of 2 files at r3, 4 of 7 files at r4.
Review status: 4 of 7 files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

glennw · 2015-11-02T20:29:03Z

@mbrubeck The compositor changes look good to me after those changes.

mbrubeck · 2015-11-02T23:15:37Z

@bors-servo r=glennw

Carrying r=jdm for the script changes; aside from rebasing, the only change was that the identifier argument get wrapped in the TouchId newtype.

bors-servo · 2015-11-02T23:15:38Z

📌 Commit c7612b1 has been approved by glennw

bors-servo · 2015-11-03T09:53:23Z

⌛ Testing commit c7612b1 with merge 2142ec1...


        Auto merge of #8232 - mbrubeck:glutin-touch, r=glennw

@glennw

Correct event dispatching for multiple simultaneous touch points Instead of just converting the mouse into a single "touch" input, Servo can now listen for multi-touch events from Glutin, maintain a list of active touch points, and dispatch events for all of them. r? @glennw (for the compositor changes) and @jdm (for the DOM changes)  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8232)

bors-servo · 2015-11-03T09:59:16Z

💔 Test failed - linux-dev

jdm · 2015-11-03T13:30:23Z

/home/servo/buildbot/slave/linux-dev/build/ports/glutin/window.rs:26:21: 26:34 error: unresolved import `script_traits::TouchEventType`. Maybe a missing `extern crate script_traits`? [E0432]
/home/servo/buildbot/slave/linux-dev/build/ports/glutin/window.rs:26 use script_traits::{TouchEventType, TouchId};
                                                                                         ^~~~~~~~~~~~~
/home/servo/buildbot/slave/linux-dev/build/ports/glutin/window.rs:26:21: 26:34 help: run `rustc --explain E0432` to see a detailed explanation
/home/servo/buildbot/slave/linux-dev/build/ports/glutin/window.rs:26:37: 27:4 error: unresolved import `script_traits::TouchId`. Maybe a missing `extern crate script_traits`? [E0432]
/home/servo/buildbot/slave/linux-dev/build/ports/glutin/window.rs:26 use script_traits::{TouchEventType, TouchId};
/home/servo/buildbot/slave/linux-dev/build/ports/glutin/window.rs:27 #[cfg(feature = "window")]
/home/servo/buildbot/slave/linux-dev/build/ports/glutin/window.rs:26:37: 27:4 help: run `rustc --explain E0432` to see a detailed explanation
error: aborting due to 2 previous errors


        Handle multi-touch events from glutin

mbrubeck · 2015-11-03T16:57:26Z

@bors-servo r=glennw

Moved an import to fix SERVO_HEADLESS builds.

bors-servo · 2015-11-03T16:57:26Z

📌 Commit ef93650 has been approved by glennw

bors-servo · 2015-11-03T17:15:22Z

⌛ Testing commit ef93650 with merge 3fdaa6e...


        Auto merge of #8232 - mbrubeck:glutin-touch, r=glennw

@glennw

Correct event dispatching for multiple simultaneous touch points Instead of just converting the mouse into a single "touch" input, Servo can now listen for multi-touch events from Glutin, maintain a list of active touch points, and dispatch events for all of them. r? @glennw (for the compositor changes) and @jdm (for the DOM changes)  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8232)

bors-servo · 2015-11-03T18:04:00Z

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

highfive added the S-awaiting-review label Oct 28, 2015

jdm added the S-fails-tidy label Oct 28, 2015

jdm added the S-needs-code-changes label Oct 28, 2015

mbrubeck force-pushed the mbrubeck:glutin-touch branch from be64b1c to 94d5d00 Oct 28, 2015

highfive removed the S-needs-code-changes label Oct 28, 2015

mbrubeck force-pushed the mbrubeck:glutin-touch branch from 94d5d00 to f634e30 Oct 28, 2015

mbrubeck removed the S-fails-tidy label Oct 28, 2015

highfive added S-needs-rebase and removed S-awaiting-merge labels Oct 28, 2015

mbrubeck force-pushed the mbrubeck:glutin-touch branch from f634e30 to 0175c61 Oct 28, 2015

mbrubeck removed the S-needs-rebase label Oct 28, 2015

mbrubeck force-pushed the mbrubeck:glutin-touch branch from 0175c61 to c7612b1 Nov 2, 2015

mbrubeck assigned glennw Nov 2, 2015

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 2, 2015

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 3, 2015

Handle multi-touch events from glutin

Loading status checks…

ef93650

mbrubeck force-pushed the mbrubeck:glutin-touch branch from c7612b1 to ef93650 Nov 3, 2015

highfive added S-awaiting-review and removed S-tests-failed labels Nov 3, 2015

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 3, 2015

This was referenced Nov 3, 2015

Get rid of a bunch of explicit derefs #8305

Merged

Make DOMString a newtype around String, rather than a typedef. #8312

Merged

Perf timing dom props #7242

Merged

mbrubeck deleted the mbrubeck:glutin-touch branch May 11, 2016

servo / servo

Correct event dispatching for multiple simultaneous touch points #8232

Correct event dispatching for multiple simultaneous touch points #8232

mbrubeck commented Oct 28, 2015

jdm commented Oct 28, 2015

mbrubeck commented Oct 28, 2015

jdm commented Oct 28, 2015

bors-servo commented Oct 28, 2015

glennw commented Nov 1, 2015

mbrubeck commented Nov 2, 2015

glennw commented Nov 2, 2015

glennw commented Nov 2, 2015

mbrubeck commented Nov 2, 2015

bors-servo commented Nov 2, 2015

bors-servo commented Nov 3, 2015

bors-servo commented Nov 3, 2015

jdm commented Nov 3, 2015

mbrubeck commented Nov 3, 2015

bors-servo commented Nov 3, 2015

bors-servo commented Nov 3, 2015

bors-servo commented Nov 3, 2015

servo / servo

Join GitHub today

Correct event dispatching for multiple simultaneous touch points #8232

Correct event dispatching for multiple simultaneous touch points #8232

Conversation

mbrubeck commented Oct 28, 2015

jdm commented Oct 28, 2015

mbrubeck commented Oct 28, 2015

jdm commented Oct 28, 2015

bors-servo commented Oct 28, 2015

glennw commented Nov 1, 2015

mbrubeck commented Nov 2, 2015

glennw commented Nov 2, 2015

glennw commented Nov 2, 2015

mbrubeck commented Nov 2, 2015

bors-servo commented Nov 2, 2015

bors-servo commented Nov 3, 2015

bors-servo commented Nov 3, 2015

jdm commented Nov 3, 2015

mbrubeck commented Nov 3, 2015

bors-servo commented Nov 3, 2015

bors-servo commented Nov 3, 2015

bors-servo commented Nov 3, 2015