Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Zeroable definition for Finite<T>. #8248

Merged
merged 1 commit into from Oct 30, 2015
Merged

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 29, 2015

I have no idea why it was added, and it appears to be unused.

Review on Reviewable

I have no idea why it was added, and it appears to be unused.
@jdm
Copy link
Member

jdm commented Oct 29, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2015

📌 Commit 04e32c7 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2015

Testing commit 04e32c7 with merge 71d17fe...

bors-servo added a commit that referenced this pull request Oct 29, 2015
Remove the Zeroable definition for Finite<T>.

I have no idea why it was added, and it appears to be unused.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8248)
<!-- Reviewable:end -->
@nox nox assigned jdm Oct 29, 2015
@Ms2ger Ms2ger closed this Oct 29, 2015
@Ms2ger Ms2ger reopened this Oct 29, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2015

Testing commit 04e32c7 with merge 475201e...

bors-servo added a commit that referenced this pull request Oct 29, 2015
Remove the Zeroable definition for Finite<T>.

I have no idea why it was added, and it appears to be unused.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8248)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2015

💔 Test failed - mac-dev-ref-unit

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Oct 29, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2015

Testing commit 04e32c7 with merge 5df730a...

bors-servo added a commit that referenced this pull request Oct 29, 2015
Remove the Zeroable definition for Finite<T>.

I have no idea why it was added, and it appears to be unused.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8248)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2015

💔 Test failed - mac-dev-ref-unit

@eefriedman
Copy link
Contributor

eefriedman commented Oct 29, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

Testing commit 04e32c7 with merge 9d1b743...

bors-servo added a commit that referenced this pull request Oct 30, 2015
Remove the Zeroable definition for Finite<T>.

I have no idea why it was added, and it appears to be unused.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8248)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

💔 Test failed - mac-rel-wpt

@eefriedman
Copy link
Contributor

eefriedman commented Oct 30, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

Testing commit 04e32c7 with merge 851e709...

bors-servo added a commit that referenced this pull request Oct 30, 2015
Remove the Zeroable definition for Finite<T>.

I have no idea why it was added, and it appears to be unused.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8248)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

💔 Test failed - linux-rel

@eefriedman
Copy link
Contributor

eefriedman commented Oct 30, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only linux-rel, mac-rel-wpt...

@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

@bors-servo bors-servo merged commit 04e32c7 into servo:master Oct 30, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:finite-zero branch Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.