Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heartbeats and energy profiling support for Android #8253

Merged
merged 2 commits into from Oct 30, 2015
Merged

Heartbeats and energy profiling support for Android #8253

merged 2 commits into from Oct 30, 2015

Conversation

@connorimes
Copy link
Contributor

connorimes commented Oct 29, 2015

Review on Reviewable
@connorimes
Update energymon dependencies.
965fbbd 
Ensure the energymon is enabled before trying to get refresh interval.
@mbrubeck mbrubeck self-assigned this Oct 29, 2015
components/util/opts.rs
@@ -223,6 +226,9 @@ pub struct DebugOptions {
/// Profile which events script tasks spend their time on.
pub profile_script_events: bool,

/// Enable all heartbeats for profiling.
pub profile_heartbeats: bool,

This comment has been minimized.

Sign in to view
Copy link
@mbrubeck

mbrubeck Oct 29, 2015

Contributor

Please add this option to the --help output below.

This comment has been minimized.

Sign in to view
Copy link
@connorimes

connorimes Oct 29, 2015

Author Contributor

Done. Also added missing line for profile-script-events.
Moved convert-mouse-to-touch to be in the same order as it is above.
@mbrubeck
Copy link
Contributor

mbrubeck commented Oct 29, 2015

r=mbrubeck with one comment above fixed
@connorimes
Heartbeats support for Android.
Loading status checks…
bb7e537 
Add debug option to enable heartbeats for all profiler categories.
@connorimes connorimes force-pushed the connorimes:android-energy-profiling branch from ce2d0d4 to bb7e537 Oct 29, 2015
@mbrubeck
Copy link
Contributor

mbrubeck commented Oct 29, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2015

📌 Commit bb7e537 has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2015

⌛ Testing commit bb7e537 with merge f4ef3ea...
bors-servo added a commit that referenced this pull request Oct 29, 2015
@bors-servo
Auto merge of #8253 - connorimes:android-energy-profiling, r=mbrubeck
f4ef3ea 
Heartbeats and energy profiling support for Android



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8253)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2015

💔 Test failed - mac-dev-ref-unit
@eefriedman
Copy link
Contributor

eefriedman commented Oct 29, 2015

@bors-servo retry #7785
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

⌛ Testing commit bb7e537 with merge 9797f8f...
bors-servo added a commit that referenced this pull request Oct 30, 2015
@bors-servo
Auto merge of #8253 - connorimes:android-energy-profiling, r=mbrubeck
9797f8f 
Heartbeats and energy profiling support for Android



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8253)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

💔 Test failed - mac-dev-ref-unit
@eefriedman
Copy link
Contributor

eefriedman commented Oct 30, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

⌛ Testing commit bb7e537 with merge f9d7960...
bors-servo added a commit that referenced this pull request Oct 30, 2015
@bors-servo
Auto merge of #8253 - connorimes:android-energy-profiling, r=mbrubeck
Loading status checks…
f9d7960 
Heartbeats and energy profiling support for Android



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8253)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

💔 Test failed - mac-rel-wpt
@eefriedman
Copy link
Contributor

eefriedman commented Oct 30, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...
@eefriedman
Copy link
Contributor

eefriedman commented Oct 30, 2015

(#7731.)
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit bb7e537 into servo:master Oct 30, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@connorimes @mbrubeck @bors-servo @eefriedman @SimonSapin @highfive
You can’t perform that action at this time.