Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write reflow results, even with no root node. #8256

Merged
merged 1 commit into from Nov 11, 2015
Merged

Write reflow results, even with no root node. #8256

merged 1 commit into from Nov 11, 2015

Conversation

@notriddle
Copy link
Contributor

notriddle commented Oct 30, 2015

Fixes #8240

Test in w3c/csswg-test#928.

Review on Reviewable
@highfive
Copy link

highfive commented Oct 30, 2015

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
@frewsxcv
Copy link
Member

frewsxcv commented Oct 31, 2015

This fails tidy

./components/layout/layout_task.rs:1157: Line is longer than 120 characters
@notriddle
Copy link
Contributor Author

notriddle commented Nov 2, 2015

Fixed the tidy errors.
@frewsxcv frewsxcv removed the S-fails-tidy label Nov 2, 2015
@eefriedman eefriedman self-assigned this Nov 2, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2015

☔ The latest upstream changes (presumably #8039) made this pull request unmergeable. Please resolve the merge conflicts.
@notriddle
Write reflow results, even with no root node.
Loading status checks…
d32a2d6 
Fixes #8240
@notriddle
Copy link
Contributor Author

notriddle commented Nov 10, 2015

What do I have to do to get w3c/csswg-test#928 reviewed? I'm tired of rebasing.
@eefriedman
Copy link
Contributor

eefriedman commented Nov 10, 2015

@bors-servo r+

I was going to wait for the test to be reviewed, but since it's taking forever, I'll just r+ this now.

Not sure our handling of empty documents is precisely correct in terms of rendering (do we have to do something here to clear the display list?), but we don't need to solve that here.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2015

📌 Commit d32a2d6 has been approved by eefriedman
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2015

⌛ Testing commit d32a2d6 with merge dc93730...
bors-servo added a commit that referenced this pull request Nov 10, 2015
@bors-servo
Auto merge of #8256 - notriddle:master, r=eefriedman
dc93730 
Write reflow results, even with no root node.

Fixes #8240

Test in w3c/csswg-test#928.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8256)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2015

💔 Test failed - gonk
@eefriedman
Copy link
Contributor

eefriedman commented Nov 10, 2015

@bors-servo retry #8416
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2015

⌛ Testing commit d32a2d6 with merge 146514c...
bors-servo added a commit that referenced this pull request Nov 10, 2015
@bors-servo
Auto merge of #8256 - notriddle:master, r=eefriedman
146514c 
Write reflow results, even with no root node.

Fixes #8240

Test in w3c/csswg-test#928.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8256)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2015

💔 Test failed - gonk
@eefriedman
Copy link
Contributor

eefriedman commented Nov 10, 2015

@bors-servo retry #8416
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2015

⌛ Testing commit d32a2d6 with merge 3e83d50...
bors-servo added a commit that referenced this pull request Nov 10, 2015
@bors-servo
Auto merge of #8256 - notriddle:master, r=eefriedman
3e83d50 
Write reflow results, even with no root node.

Fixes #8240

Test in w3c/csswg-test#928.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8256)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2015

💔 Test failed - gonk
@jdm
Copy link
Member

jdm commented Nov 10, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2015

⌛ Testing commit d32a2d6 with merge 532f9a0...
bors-servo added a commit that referenced this pull request Nov 10, 2015
@bors-servo
Auto merge of #8256 - notriddle:master, r=eefriedman
Loading status checks…
532f9a0 
Write reflow results, even with no root node.

Fixes #8240

Test in w3c/csswg-test#928.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8256)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 11, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit d32a2d6 into servo:master Nov 11, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eefriedman eefriedman

Labels
S-awaiting-merge S-blocked-on-external
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@notriddle @highfive @frewsxcv @bors-servo @eefriedman @jdm
You can’t perform that action at this time.