Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAttempt to fix webfont-related intermittent test failures. #8257
Conversation
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Oct 30, 2015
Attempt to fix webfont-related intermittent test failures. I'm not completely sure the race condition outlined in this patch is actually the race condition causing failures... but it's a possibility. (I plan to run this through try a couple of times to see if it actually helps.) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8257) <!-- Reviewable:end -->
|
Yikes, that's subtle. |
|
|
|
@bors-servo retry #7731 |
bors-servo
added a commit
that referenced
this pull request
Oct 30, 2015
Attempt to fix webfont-related intermittent test failures. I'm not completely sure the race condition outlined in this patch is actually the race condition causing failures... but it's a possibility. (I plan to run this through try a couple of times to see if it actually helps.) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8257) <!-- Reviewable:end -->
|
|
|
@bors-servo try |
I'm not completely sure the race condition outlined in this patch is actually the race condition causing failures... but it seems reasonable.
eefriedman
force-pushed the
eefriedman:reorder-webfont-check
branch
from
ec2fd77
to
4f86662
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Oct 30, 2015
Attempt to fix webfont-related intermittent test failures. I'm not completely sure the race condition outlined in this patch is actually the race condition causing failures... but it's a possibility. (I plan to run this through try a couple of times to see if it actually helps.) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8257) <!-- Reviewable:end -->
|
|
|
Three tries, zero font-related failures; either this fixes the issue, or I'm extremely unlucky. |
|
@bors-servo r+ p=1 Nice find! |
|
|
|
@bors-servo retry |
|
@bors-servo r=mbrubeck |
|
|
|
@bors-servo r- |
|
@bors-servo r=mbrubeck p=1 |
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Oct 30, 2015
Attempt to fix webfont-related intermittent test failures. I'm not completely sure the race condition outlined in this patch is actually the race condition causing failures... but it's a possibility. (I plan to run this through try a couple of times to see if it actually helps.) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8257) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
eefriedman commentedOct 30, 2015
I'm not completely sure the race condition outlined in this patch is
actually the race condition causing failures... but it's a possibility.
(I plan to run this through try a couple of times to see if it actually helps.)