Mix stacking contexts into the positioned content list #8266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highfive
added
the
S-awaiting-review
|
@pcwalton r? This is the main prerequisite for eliminating |
mrobinson
force-pushed
the
stacking-context-mix
branch
2 times, most recently
from
88b6ca2
to
5c63287
Compare
This was referenced Nov 2, 2015
mrobinson
force-pushed
the
stacking-context-mix
branch
from
5c63287
to
90a16a4
Compare
| @@ -206,23 +204,31 @@ impl DisplayList { | |||
| /// inefficient and should only be used for debugging. | |||
| pub fn all_display_items(&self) -> Vec<DisplayItem> { | |||
| let mut result = Vec::new(); | |||
| fn add_all_display_items_for_item(result: &mut Vec<DisplayItem>, item: &DisplayItem) { | |||
There was a problem hiding this comment.
Maybe just call this flatten? That's the terminology WR uses for a similar operation.
mrobinson
force-pushed
the
stacking-context-mix
branch
from
90a16a4
to
a2acb2a
Compare
|
@pcwalton Thanks, as always, for the review comments. I think I've made all the changes you suggested in the latest version of the branch. Do you see any other issues here? |
gilles-leblanc
referenced
this pull request
in gilles-leblanc/servo
Nov 3, 2015
Adding overflow:hidden to an absolute positioned div will change it's stacking order. referencing servo#8122
This was referenced Nov 3, 2015
|
Not sure if you want to address this issue in this PR or not, but for the record: #8310 |
mrobinson
force-pushed
the
stacking-context-mix
branch
from
a2acb2a
to
5b3e953
Compare
|
@paulrouget Thanks for finding that issue! I've fixed it in the latest version. I had omitted some code that was removed. |
|
@bors-servo: r+ |
|
📌 Commit 5b3e953 has been approved by |
highfive
added
S-awaiting-merge
|
@bors-servo: r- @mrobinson wants to add a test |
|
@bors-servo: r+ |
|
📌 Commit 5b3e953 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 3, 2015
Mix stacking contexts into the positioned content list Sometimes positioned content needs to be layered on top of stacking contexts. The layer synthesis code can do this, but the current design prevents it because stacking contexts are stored in a separate struct member. In order to preserve tree order, mix stacking contexts into the positioned content list, by adding a new StackingContextClass DisplayItem. Such items do not have a base DisplayItem. In some ways this simplifies the code, because we no longer have to have a separate code path in the StackingContextLayerCreator. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8266) <!-- Reviewable:end -->
|
💔 Test failed - linux-rel |
highfive
added
S-tests-failed
|
Looks like some tests are now passing with this change. I'll update the branch and reupload. |
Sometimes positioned content needs to be layered on top of stacking contexts. The layer synthesis code can do this, but the current design prevents it because stacking contexts are stored in a separate struct member. In order to preserve tree order, mix stacking contexts into the positioned content list, by adding a new StackingContextClass DisplayItem. Such items do not have a base DisplayItem. In some ways this simplifies the code, because we no longer have to have a separate code path in the StackingContextLayerCreator. Fixes servo#7779. Fixes servo#7983. Fixes servo#8122. Fixes servo#8310.
mrobinson
force-pushed
the
stacking-context-mix
branch
from
5b3e953
to
c1a38e2
Compare
highfive
added
S-awaiting-review
|
@bors-servo: r=pcwalton I confirmed with @pcwalton via IRC that he was okay with trying to land this again. |
|
📌 Commit c1a38e2 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Nov 4, 2015
Mix stacking contexts into the positioned content list Sometimes positioned content needs to be layered on top of stacking contexts. The layer synthesis code can do this, but the current design prevents it because stacking contexts are stored in a separate struct member. In order to preserve tree order, mix stacking contexts into the positioned content list, by adding a new StackingContextClass DisplayItem. Such items do not have a base DisplayItem. In some ways this simplifies the code, because we no longer have to have a separate code path in the StackingContextLayerCreator. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8266) <!-- Reviewable:end -->
|
☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes positioned content needs to be layered on top of stacking
contexts. The layer synthesis code can do this, but the current design
prevents it because stacking contexts are stored in a separate struct
member. In order to preserve tree order, mix stacking contexts into the
positioned content list, by adding a new StackingContextClass
DisplayItem. Such items do not have a base DisplayItem.
In some ways this simplifies the code, because we no longer have to
have a separate code path in the StackingContextLayerCreator.