Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements. #8267

Merged
merged 6 commits into from Oct 30, 2015
Merged

Various improvements. #8267

merged 6 commits into from Oct 30, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 30, 2015

Review on Reviewable
Ms2ger added 5 commits Oct 30, 2015
@Ms2ger
Avoid a Vec copy in SendParam::extract.
b0841e0
@Ms2ger
Use if let in ScriptTask::notify_devtools.
2f88264
@Ms2ger
Avoid string copies in handle_find_{element,elements}_css.
a67eaa2
@Ms2ger
Support unions that contain USVStrings.
7ccc5ad
@Ms2ger
Update URLSearchParams to use USVString and String.
Loading status checks…
e8914cd 
This matches the specification.
@Ms2ger
Remove the pointless TextEncoder::encoding field.
Loading status checks…
48c232f
@frewsxcv
Copy link
Member

frewsxcv commented Oct 30, 2015

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 3 of 3 files at r4, 2 of 2 files at r5, 1 of 1 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io
@frewsxcv
Copy link
Member

frewsxcv commented Oct 30, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

📌 Commit 48c232f has been approved by frewsxcv
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

⌛ Testing commit 48c232f with merge b7e4a2b...
bors-servo added a commit that referenced this pull request Oct 30, 2015
@bors-servo
Auto merge of #8267 - Ms2ger:cleanup, r=frewsxcv
b7e4a2b 
Various improvements.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8267)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

💔 Test failed - mac-dev-ref-unit
@frewsxcv
Copy link
Member

frewsxcv commented Oct 30, 2015

@bors-servo retry

#7785
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

⌛ Testing commit 48c232f with merge 1dfc048...
bors-servo added a commit that referenced this pull request Oct 30, 2015
@bors-servo
Auto merge of #8267 - Ms2ger:cleanup, r=frewsxcv
Loading status checks…
1dfc048 
Various improvements.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8267)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 48c232f into servo:master Oct 30, 2015
3 checks passed
3 checks passed
code-review/reviewable Review complete: all files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Oct 30, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Ms2ger @frewsxcv @bors-servo @highfive
You can’t perform that action at this time.