Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upM1506 : Refactor GLES2 #8277
Closed
M1506 : Refactor GLES2 #8277
+12
−1
Conversation
highfive
commented
Oct 30, 2015
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon. |
|
Thanks for the PR! Note: This depends on servo/rust-layers#213. [EDIT: Deleted my initial comment, which was confused.] |
|
|
|
Given #8869 I don't believe this PR is necessary any longer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
prashantgupta24 commentedOct 30, 2015
This contains the new command line option to allow selecting the graphics backend (GL or ES2) in components/utils/opts.rs, and use the new command line option to pass an appropriate value in initialize_compositing in components/compositing/compositor.rs