Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expected failures for send-entity-body-document.htm. #8289

Closed
wants to merge 1 commit into from

Conversation

@eefriedman
Copy link
Contributor

eefriedman commented Oct 31, 2015

Fixes #8157.

Review on Reviewable

@jdm
Copy link
Member

jdm commented Nov 1, 2015

This doesn't seem like a useful change right now; the test was disabled because the failures only appeared intermittently on OS X, which makes merging things harder.

@eefriedman
Copy link
Contributor Author

eefriedman commented Nov 1, 2015

The tests all fail consistently. They just don't run consistently, which is what causes the intermittent failures.

@jdm
Copy link
Member

jdm commented Nov 1, 2015

Yes, that distinction is true. I don't understand the benefit of re-enabling this test while the results are not consistent, however.

@eefriedman
Copy link
Contributor Author

eefriedman commented Nov 1, 2015

Whatever, I'll just leave it alone for now.

@eefriedman eefriedman closed this Nov 1, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 2, 2015

If these tests don't run consistently, would these annotations make everything finish successfully?

@eefriedman
Copy link
Contributor Author

eefriedman commented Nov 2, 2015

They would, I think. (At least, they do in my brief testing.) The test runner ignores annotations for tests which aren't run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.