Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanup. #8295

Merged
merged 2 commits into from Nov 3, 2015
Merged

Various cleanup. #8295

merged 2 commits into from Nov 3, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 2, 2015

Review on Reviewable
Ms2ger added 2 commits Nov 2, 2015
@Ms2ger
Avoid some string copies in handle_modify_attribute.
13291c4
@Ms2ger
Simplify DOMTokenList::Item.
Loading status checks…
d3d1f2b
@jdm
Copy link
Member

jdm commented Nov 2, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2015

📌 Commit d3d1f2b has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2015

⌛ Testing commit d3d1f2b with merge 6bdeeca...
bors-servo added a commit that referenced this pull request Nov 2, 2015
@bors-servo
Auto merge of #8295 - Ms2ger:cleanup, r=jdm
6bdeeca 
Various cleanup.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8295)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2015

💔 Test failed - mac-rel-wpt
@jdm
Copy link
Member

jdm commented Nov 2, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only linux-rel, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Nov 2, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only linux-rel, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2015

💔 Test failed - mac-rel-wpt
@jdm
Copy link
Member

jdm commented Nov 2, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only linux-rel, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Nov 2, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Nov 2, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2015

⌛ Testing commit d3d1f2b with merge 1794e58...
bors-servo added a commit that referenced this pull request Nov 3, 2015
@bors-servo
Auto merge of #8295 - Ms2ger:cleanup, r=jdm
Loading status checks…
1794e58 
Various cleanup.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8295)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit d3d1f2b into servo:master Nov 3, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Nov 3, 2015
Closed
@Ms2ger Ms2ger deleted the Ms2ger:cleanup branch Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Ms2ger @jdm @bors-servo @highfive
You can’t perform that action at this time.