Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layout: Avoid flooding the compositor with animation state changes if there are no animations running and no new animations were added. #8300

Merged
merged 1 commit into from Nov 3, 2015
Merged

layout: Avoid flooding the compositor with animation state changes if there are no animations running and no new animations were added. #8300

merged 1 commit into from Nov 3, 2015

Conversation

pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Nov 3, 2015

Avoids compositor jank during scroll.

r? @glennw

Review on Reviewable

@pcwalton
layout: Avoid flooding the compositor with animation state changes if
8d58197 
there are no animations running and no new animations were added.

Avoids compositor jank during scroll.
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 3, 2015
@highfive
Copy link

highfive commented Nov 3, 2015

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!

@glennw
Copy link
Member

glennw commented Nov 3, 2015

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 8d58197 has been approved by glennw

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 3, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit 8d58197 with merge 27fb2ed...

bors-servo pushed a commit that referenced this pull request Nov 3, 2015
Auto merge of #8300 - pcwalton:avoid-animation-state-flooding, r=glennw
27fb2ed 
layout: Avoid flooding the compositor with animation state changes if there are no animations running and no new animations were added.

Avoids compositor jank during scroll.

r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8300)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 3, 2015
@jdm
Copy link
Member

jdm commented Nov 3, 2015

@bors-servo: retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit are reusable. Rebuilding only linux-rel, mac-rel-css, mac-rel-wpt...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit 8d58197 into servo:master Nov 3, 2015
@SimonSapin SimonSapin removed the S-tests-failed The changes caused existing tests to fail. label Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glennw glennw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pcwalton @highfive @glennw @bors-servo @jdm @SimonSapin