Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup some unneeded let bindings #8304

Merged
merged 1 commit into from Nov 6, 2015
Merged

Cleanup some unneeded let bindings #8304

merged 1 commit into from Nov 6, 2015

Conversation

@dzbarsky
Copy link
Member

dzbarsky commented Nov 3, 2015

Review on Reviewable

@dzbarsky dzbarsky force-pushed the dzbarsky:borrowck branch from 3832120 to f02885e Nov 3, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 3, 2015

-S-awaiting-review +S-needs-code-changes


Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


ports/cef/window.rs, line 472 [r1] (raw file):
This does not look correct.


Comments from the review on Reviewable.io

@Ms2ger Ms2ger self-assigned this Nov 3, 2015
@dzbarsky
Copy link
Member Author

dzbarsky commented Nov 4, 2015

Review status: all files reviewed at latest revision, 1 unresolved discussion.


ports/cef/window.rs, line 472 [r1] (raw file):
I was guessing here, what's the problem? (Is there a way to compile the CEF port on OSX?)


Comments from the review on Reviewable.io

@eefriedman
Copy link
Contributor

eefriedman commented Nov 4, 2015

Review status: all files reviewed at latest revision, 1 unresolved discussion.


ports/cef/window.rs, line 472 [r1] (raw file):
Among other things, the variable frame_url isn't defined anywhere.


Comments from the review on Reviewable.io

@jdm
Copy link
Member

jdm commented Nov 4, 2015

./mach build-cef

@dzbarsky dzbarsky force-pushed the dzbarsky:borrowck branch from f02885e to fcfa0e7 Nov 4, 2015
@dzbarsky
Copy link
Member Author

dzbarsky commented Nov 4, 2015

OK it actually builds now

@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

The latest upstream changes (presumably #8305) made this pull request unmergeable. Please resolve the merge conflicts.

@dzbarsky dzbarsky force-pushed the dzbarsky:borrowck branch from fcfa0e7 to 676e8a1 Nov 4, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 4, 2015

Reviewed 5 of 5 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


ports/cef/window.rs, line 472 [r1] (raw file):
You no longer update servoframe.url. Just revert these changes, please.


Comments from the review on Reviewable.io

@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

The latest upstream changes (presumably #8312) made this pull request unmergeable. Please resolve the merge conflicts.

@dzbarsky
Copy link
Member Author

dzbarsky commented Nov 5, 2015

Ok done

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 5, 2015

Needs a rebase now.

@jdm jdm removed the S-awaiting-review label Nov 5, 2015
@dzbarsky dzbarsky force-pushed the dzbarsky:borrowck branch from 1329572 to dfc90db Nov 6, 2015
@dzbarsky
Copy link
Member Author

dzbarsky commented Nov 6, 2015

Rebased.

@jdm jdm removed the S-needs-rebase label Nov 6, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 6, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2015

📌 Commit dfc90db has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2015

Testing commit dfc90db with merge 69e6eb4...

bors-servo added a commit that referenced this pull request Nov 6, 2015
Cleanup some unneeded let bindings

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8304)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2015

@bors-servo bors-servo merged commit dfc90db into servo:master Nov 6, 2015
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable Review in progress: 1 of 4 files reviewed, 1 unresolved discussion
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.