Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of a bunch of explicit derefs #8305

Merged
merged 1 commit into from Nov 4, 2015
Merged

Get rid of a bunch of explicit derefs #8305

merged 1 commit into from Nov 4, 2015
+340 −360

Conversation

@dzbarsky
Copy link
Member

dzbarsky commented Nov 3, 2015

Review on Reviewable
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 3, 2015

-S-awaiting-review +S-needs-code-changes
R? @Ms2ger

Reviewed 49 of 49 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

components/script/dom/uievent.rs, line 51 [r1] (raw file):
Indent.

components/script/script_task.rs, line 871 [r1] (raw file):
Indent

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2015

☔ The latest upstream changes (presumably #8232) made this pull request unmergeable. Please resolve the merge conflicts.
@dzbarsky dzbarsky force-pushed the dzbarsky:roots branch from fadf503 to 722aa86 Nov 4, 2015
@dzbarsky
Get rid of a bunch of explicit derefs
Loading status checks…
722aa86
@dzbarsky
Copy link
Member Author

dzbarsky commented Nov 4, 2015

Thanks, I looked through the diff before submitting, but I'm always impressed by your ability to catch those
@tetsuharuohzeki
Copy link
Member

tetsuharuohzeki commented Nov 4, 2015

@bors-servo r=Ms2ger, saneyuki
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

📌 Commit 722aa86 has been approved by Ms2ger,
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

⌛ Testing commit 722aa86 with merge 4b9fa13...
bors-servo added a commit that referenced this pull request Nov 4, 2015
@bors-servo
Auto merge of #8305 - dzbarsky:roots, r=Ms2ger,
Loading status checks…
4b9fa13 
Get rid of a bunch of explicit derefs



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8305)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

💔 Test failed - mac-rel-wpt
@jdm
Copy link
Member

jdm commented Nov 4, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 722aa86 into servo:master Nov 4, 2015
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable Review in progress: 0 of 49 files reviewed, 2 unresolved discussions
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Nov 4, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@dzbarsky @Ms2ger @bors-servo @tetsuharuohzeki @jdm @SimonSapin @highfive
You can’t perform that action at this time.