Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change overflow calculation to be calculated after compute_absolute_position. #8306

Merged
merged 1 commit into from Nov 4, 2015
Merged

Change overflow calculation to be calculated after compute_absolute_position. #8306

merged 1 commit into from Nov 4, 2015

Conversation

@glennw
Copy link
Member

glennw commented Nov 3, 2015

Also include absolutely positioned elements in the overflow rect calculation.

Fixes #7797.

Review on Reviewable
@glennw
Copy link
Member Author

glennw commented Nov 3, 2015

@pcwalton Does this change seem reasonable to you?

As far as I can tell, all tests pass and it fixes the referenced issue.

The overflow rect is only read by the display list building pass, so it appears to be safe to move the calculation to a later pass. However, the code seems so much simpler that I wonder if I'm missing something like a particular edge case or performance issue with this approach?
tests/wpt/mozilla/tests/css/abs-overflow-stackingcontext_ref.html Outdated
<!DOCTYPE html>
<html>
<head>
<link rel='match' href='abs-overflow-stackingcontext_ref.html'>

This comment has been minimized.

Sign in to view
Copy link
@Ms2ger

Ms2ger Nov 3, 2015

Contributor

rm. What's the difference between the test and the reference?

This comment has been minimized.

Sign in to view
Copy link
@glennw

glennw Nov 3, 2015

Author Member

Argh, I accidentally removed the perspective field - good catch. I'll update shortly.
@gw3583
Change overflow calculation to be calculated after compute_absolute_p…
Loading status checks…
695b749 
…osition.

Also include absolutely positioned elements in the overflow rect calculation.

Fixes #7797.
@glennw glennw force-pushed the glennw:fix-abd-overflow branch from d7f078c to 695b749 Nov 3, 2015
@metajack metajack assigned metajack and pcwalton and unassigned metajack Nov 3, 2015
@pcwalton
Copy link
Contributor

pcwalton commented Nov 4, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

📌 Commit 695b749 has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

⌛ Testing commit 695b749 with merge ca56ebb...
bors-servo added a commit that referenced this pull request Nov 4, 2015
@bors-servo
Auto merge of #8306 - glennw:fix-abd-overflow, r=pcwalton
Loading status checks…
ca56ebb 
Change overflow calculation to be calculated after compute_absolute_position.

Also include absolutely positioned elements in the overflow rect calculation.

Fixes #7797.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8306)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo mentioned this pull request Nov 4, 2015
Merged
@bors-servo bors-servo merged commit 695b749 into servo:master Nov 4, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@pcwalton pcwalton mentioned this pull request Mar 17, 2016
Merged
@glennw glennw deleted the glennw:fix-abd-overflow branch Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@glennw @pcwalton @bors-servo @Ms2ger @metajack @highfive @gw3583
You can’t perform that action at this time.