Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead load_sync function. #8318

Merged
merged 1 commit into from Nov 4, 2015
Merged

Remove dead load_sync function. #8318

merged 1 commit into from Nov 4, 2015
+1 −9

Conversation

@eefriedman
Copy link
Contributor

eefriedman commented Nov 3, 2015

Review on Reviewable
@eefriedman
Remove dead load_sync function.
Loading status checks…
193d8f2
@jdm
Copy link
Member

jdm commented Nov 3, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2015

📌 Commit 193d8f2 has been approved by jdm
@jdm jdm self-assigned this Nov 3, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

⌛ Testing commit 193d8f2 with merge 2f90dfb...
bors-servo added a commit that referenced this pull request Nov 4, 2015
@bors-servo
Auto merge of #8318 - eefriedman:dead-sync-load, r=jdm
2f90dfb 
Remove dead load_sync function.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8318)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Nov 4, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit are reusable. Rebuilding only linux-rel, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

💔 Test failed - linux-rel
@eefriedman
Copy link
Contributor Author

eefriedman commented Nov 4, 2015

@bors-servo retry #8311
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

⌛ Testing commit 193d8f2 with merge 94878e9...
bors-servo added a commit that referenced this pull request Nov 4, 2015
@bors-servo
Auto merge of #8318 - eefriedman:dead-sync-load, r=jdm
94878e9 
Remove dead load_sync function.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8318)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Nov 4, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

⌛ Testing commit 193d8f2 with merge 1fdd8da...
bors-servo added a commit that referenced this pull request Nov 4, 2015
@bors-servo
Auto merge of #8318 - eefriedman:dead-sync-load, r=jdm
1fdd8da 
Remove dead load_sync function.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8318)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

💔 Test failed - linux-rel
@eefriedman
Copy link
Contributor Author

eefriedman commented Nov 4, 2015

@bors-servo retry #8311
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

⌛ Testing commit 193d8f2 with merge 7b85bcf...
bors-servo added a commit that referenced this pull request Nov 4, 2015
@bors-servo
Auto merge of #8318 - eefriedman:dead-sync-load, r=jdm
7b85bcf 
Remove dead load_sync function.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8318)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

💔 Test failed - mac-rel-wpt
@jdm
Copy link
Member

jdm commented Nov 4, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

⌛ Testing commit 193d8f2 with merge 50e0c36...
bors-servo added a commit that referenced this pull request Nov 4, 2015
@bors-servo
Auto merge of #8318 - eefriedman:dead-sync-load, r=jdm
Loading status checks…
50e0c36 
Remove dead load_sync function.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8318)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 193d8f2 into servo:master Nov 4, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@eefriedman @jdm @bors-servo @highfive
You can’t perform that action at this time.