Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly resize iframe root layers #8322

Merged
merged 1 commit into from Nov 4, 2015
Merged

Conversation

@mrobinson
Copy link
Member

mrobinson commented Nov 3, 2015

When a layer containing an iframe changes, we also need to resize the
root layer of the subpage. This ensures that content from the child
layer tree is masked to the new size.

Fixes #8301.

Review on Reviewable

When a layer containing an iframe changes, we also need to resize the
root layer of the subpage. This ensures that content from the child
layer tree is masked to the new size.

Fixes #8301.
@mrobinson
Copy link
Member Author

mrobinson commented Nov 3, 2015

@pcwalton
Copy link
Contributor

pcwalton commented Nov 4, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

📌 Commit 261246e has been approved by pcwalton

@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

Testing commit 261246e with merge 4b31292...

bors-servo added a commit that referenced this pull request Nov 4, 2015
Properly resize iframe root layers

When a layer containing an iframe changes, we also need to resize the
root layer of the subpage. This ensures that content from the child
layer tree is masked to the new size.

Fixes #8301.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8322)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

💔 Test failed - linux-rel

@eefriedman
Copy link
Contributor

eefriedman commented Nov 4, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

Testing commit 261246e with merge 4052ddd...

bors-servo added a commit that referenced this pull request Nov 4, 2015
Properly resize iframe root layers

When a layer containing an iframe changes, we also need to resize the
root layer of the subpage. This ensures that content from the child
layer tree is masked to the new size.

Fixes #8301.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8322)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

💔 Test failed - mac-rel-wpt

@mrobinson
Copy link
Member Author

mrobinson commented Nov 4, 2015

@jdm
Copy link
Member

jdm commented Nov 4, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

Testing commit 261246e with merge dc159d0...

bors-servo added a commit that referenced this pull request Nov 4, 2015
Properly resize iframe root layers

When a layer containing an iframe changes, we also need to resize the
root layer of the subpage. This ensures that content from the child
layer tree is masked to the new size.

Fixes #8301.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8322)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

@bors-servo bors-servo merged commit 261246e into servo:master Nov 4, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mrobinson mrobinson deleted the mrobinson:iframe-resizing branch Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.