Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print process output for TIMEOUT status in WPT UI #8323

Merged
merged 1 commit into from Nov 4, 2015

Conversation

@mrobinson
Copy link
Member

mrobinson commented Nov 3, 2015

Tests can time out due to script or runtime errors, which are typically
reported via the Servo process output. Including process output for tests
timing out makes it easier to understand these problems.

Review on Reviewable

Tests can time out due to script or runtime errors, which are typically
reported via the Servo process output. Including process output for tests
timing out makes it easier to understand these problems.
@mrobinson
Copy link
Member Author

mrobinson commented Nov 3, 2015

@jgraham
Copy link
Contributor

jgraham commented Nov 4, 2015

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@jgraham
Copy link
Contributor

jgraham commented Nov 4, 2015

Someone tell homu r+, please?

@mrobinson
Copy link
Member Author

mrobinson commented Nov 4, 2015

@bors-servo r=jgraham

@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

📌 Commit 4a23f6f has been approved by jgraham

@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

Testing commit 4a23f6f with merge 664727e...

bors-servo added a commit that referenced this pull request Nov 4, 2015
Print process output for TIMEOUT status in WPT UI

Tests can time out due to script or runtime errors, which are typically
reported via the Servo process output. Including process output for tests
timing out makes it easier to understand these problems.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8323)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

💔 Test failed - mac-rel-wpt

@eefriedman
Copy link
Contributor

eefriedman commented Nov 4, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

Testing commit 4a23f6f with merge 37201e3...

bors-servo added a commit that referenced this pull request Nov 4, 2015
Print process output for TIMEOUT status in WPT UI

Tests can time out due to script or runtime errors, which are typically
reported via the Servo process output. Including process output for tests
timing out makes it easier to understand these problems.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8323)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2015

@bors-servo bors-servo merged commit 4a23f6f into servo:master Nov 4, 2015
3 checks passed
3 checks passed
code-review/reviewable Review complete: all files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mrobinson mrobinson deleted the mrobinson:wpt-ui-timeout branch Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.