Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print process output for TIMEOUT status in WPT UI #8323

Merged
merged 1 commit into from Nov 4, 2015
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Print process output for TIMEOUT status in WPT UI

Tests can time out due to script or runtime errors, which are typically
reported via the Servo process output. Including process output for tests
timing out makes it easier to understand these problems.
  • Loading branch information
mrobinson committed Nov 3, 2015
commit 4a23f6f2d057ef4186eac12d8b37bb5821aa5421
@@ -167,9 +167,10 @@ def test_end(self, data):
self.expected[test_status] += 1
return self.generate_output(text=None, new_display=new_display)

# If the test crashed, we also include any process output, because there is a good
# chance that the test produced a stack trace.
if test_status == "CRASH":
# If the test crashed or timed out, we also include any process output,
# because there is a good chance that the test produced a stack trace
# or other error messages.
if test_status in ("CRASH", "TIMEOUT"):
stack = self.test_output[test_name] + data.get('stack', "")
else:
stack = data.get('stack', None)
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.