Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restyle hints to handle non-last psuedo-selectors, and track pristine state values rather than changesets #8341

Merged
merged 3 commits into from Nov 7, 2015

Commits on Nov 5, 2015

  1. Consider all the pseudo-classes in a given compound selector when com…

    …puting restyle hints, not just the rightmost one.
    
    For some reason when I wrote this code I mixed up the rules for pseudo-elements
    (rightmost, maximum of one) with those of pseudo-classes (which have no such
    restriction). This caused a correctness issue which can be demonstrated with the
    associated reftest modification.
    bholley committed Nov 5, 2015
  2. Store pristine element state rather than a set of changes.

    This is the strategy we'll need to take for attributes, and so this change
    puts us in a position to handle attributes and state the same way.
    
    This does mean that we stop taking care to track the situations where our
    state has reverted to the original state, with no net change. I think that's
    probably of negligible value though.
    bholley committed Nov 5, 2015
You can’t perform that action at this time.