Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wptrunner for some old-style reftests. #8354

Merged
merged 8 commits into from Nov 5, 2015
Merged

Use wptrunner for some old-style reftests. #8354

merged 8 commits into from Nov 5, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 5, 2015

Review on Reviewable
Ms2ger added 8 commits Nov 5, 2015
@Ms2ger
Move fixed_width_overrides_child_intrinsic_width_a.html to wpt reftests.
4add7d2
@Ms2ger
Move flex_column_direction.html to wpt reftests.
9623ed5
@Ms2ger
Move flex_row_direction.html to wpt reftests.
c8f0613
@Ms2ger
Move floated_negative_margins_a.html to wpt reftests.
5b35ee0
@Ms2ger
Move font_size.html to wpt reftests.
0cf602f
@Ms2ger
Move image_rendering_auto_a.html and image_rendering_pixelated_a.html…
41a9502 
… to wpt reftests.
@Ms2ger
Move img_block_maxwidth_a.html and img_block_maxwidth_b.html to wpt r…
31476b7 
…eftests.
@Ms2ger
Move img_simple.html to wpt reftests.
Loading status checks…
e403459
@frewsxcv frewsxcv self-assigned this Nov 5, 2015
@frewsxcv
Copy link
Member

frewsxcv commented Nov 5, 2015

tests/ref/basic.list, line 14 [r1] (raw file):
Should we be concerned about not transitioning these prefs?

Comments from the review on Reviewable.io
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 5, 2015

Review status: 0 of 22 files reviewed at latest revision, 1 unresolved discussion.

tests/ref/basic.list, line 14 [r1] (raw file):
They're on by default for all our own test.

Comments from the review on Reviewable.io
@frewsxcv
Copy link
Member

frewsxcv commented Nov 5, 2015

@bors-servo r+

Reviewed 6 of 6 files at r1, 6 of 6 files at r2, 6 of 6 files at r3, 6 of 6 files at r4, 6 of 6 files at r5, 9 of 9 files at r6, 8 of 8 files at r7, 7 of 7 files at r8.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2015

📌 Commit e403459 has been approved by frewsxcv
@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2015

⌛ Testing commit e403459 with merge bc9970d...
bors-servo added a commit that referenced this pull request Nov 5, 2015
@bors-servo
Auto merge of #8354 - Ms2ger:test-ref, r=frewsxcv
Loading status checks…
bc9970d 
Use wptrunner for some old-style reftests.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8354)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit e403459 into servo:master Nov 5, 2015
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable Review in progress: all files reviewed, 1 unresolved discussion
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2015

☔ The latest upstream changes (presumably #8354) made this pull request unmergeable. Please resolve the merge conflicts.
@bors-servo bors-servo mentioned this pull request Nov 5, 2015
Merged
@Ms2ger Ms2ger deleted the Ms2ger:test-ref branch Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frewsxcv frewsxcv

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Ms2ger @frewsxcv @bors-servo @highfive
You can’t perform that action at this time.