Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest glutin #8357

Merged
merged 1 commit into from Nov 5, 2015
Merged

Upgrade to latest glutin #8357

merged 1 commit into from Nov 5, 2015

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Nov 5, 2015

@highfive
Copy link

highfive commented Nov 5, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@metajack
Copy link
Contributor

metajack commented Nov 5, 2015

@bors-servo r+

I'm slightly concerned that xml5ever was missing from two deps and CI didn't catch it.


Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2015

📌 Commit ce61dc2 has been approved by metajack

@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2015

Testing commit ce61dc2 with merge 65a0bb4...

bors-servo added a commit that referenced this pull request Nov 5, 2015
Upgrade to latest glutin

Includes servo/glutin#52 and servo/glutin#53.

r? @glennw cc @vvuk

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8357)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2015

@bors-servo bors-servo merged commit ce61dc2 into servo:master Nov 5, 2015
3 checks passed
3 checks passed
code-review/reviewable Review complete: all files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.