Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd CCACHE infra and turn it on in travis #8366
Conversation
|
@bors-servo r+ |
|
|
|
@bors-servo r- This causes Travis to fail. We should make it a policy to let Travis finish if the config file ever changes. |
|
wat |
|
It might be worth going this route: http://docs.travis-ci.com/user/caching/#ccache-cache ? |
|
@frewsxcv That does the same thing (but also adds it to the PATH, which we don't need). I think there's something deeper going on, and I'll try to dig in tomorrow. I'm not sure how this is working at all today, as the travis validator claims that what we have right now gets most of its content thrown out because they're not valid in those parts of the file. |
|
FWIW, I don't know think the current caching statements in the config do anything |
|
Asked about this on IRC. A response I got: It might be worth adding the |
|
This is green! Can I get a re-r+ including the new bit? |
|
@bors-servo r+ |
|
|
Add CCACHE infra and turn it on in travis r? @Manishearth This lets devs configure their use of CCACHE with their .servobuild file, as usual. For build environments, they can either have a .servobuild file or set the CCACHE env var to point at the ccache binary to use. It also adds support for ccache to our travis builds. Buildbot will come in a separate commit to the saltfs repo. It is expected that the various cargo makefiles will look at this variable and do the "right thing" to tell their native build to instead use ccache. e.g., servo/mozjs#62 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8366) <!-- Reviewable:end -->
|
|
Update mozjs r? @Manishearth This mainly just picks up the support for ccache. I'd like to get one module using it to land to see how it works on Travis & the builders (probably should have done this along with #8366). <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8387) <!-- Reviewable:end -->
Update mozjs r? @Manishearth This mainly just picks up the support for ccache. I'd like to get one module using it to land to see how it works on Travis & the builders (probably should have done this along with #8366). <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8387) <!-- Reviewable:end -->
larsbergstrom commentedNov 5, 2015
r? @Manishearth
This lets devs configure their use of CCACHE with their .servobuild file, as usual. For build environments, they can either have a .servobuild file or set the CCACHE env var to point at the ccache binary to use.
It also adds support for ccache to our travis builds. Buildbot will come in a separate commit to the saltfs repo.
It is expected that the various cargo makefiles will look at this variable and do the "right thing" to tell their native build to instead use ccache. e.g., servo/mozjs#62