Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCSS test fonts #8374
CSS test fonts #8374
Conversation
highfive
commented
Nov 6, 2015
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. |
|
@bors-servo try |
CSS test fonts This adds an up-to-date set of CSS tests fonts, specifically the subset that can be installed for all tests. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8374) <!-- Reviewable:end -->
|
|
|
|
The only failure is #7791. |
|
Hmm. All of /css-fonts-3_dev/html/font-size-* reproducibly fail here…Will look into it. Probably more just intermittent failures. |
|
These seem to all pass reliably on OS X, and fail on Linux. |
|
@bors-servo try |
CSS test fonts This adds an up-to-date set of CSS tests fonts, specifically the subset that can be installed for all tests. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8374) <!-- Reviewable:end -->
|
|
|
Can anyone give any insight into that failure? Or what I should do? (It looks wholly unrelated to anything I've touched!) |
|
@bors-servo retry #7731 |
CSS test fonts This adds an up-to-date set of CSS tests fonts, specifically the subset that can be installed for all tests. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8374) <!-- Reviewable:end -->
|
It's an intermittent, don't worry. |
|
I don't see the point of retrying on try for known intermittents. |
|
|
|
hrm, I may have to switch the android builder to something with more RAM |
|
I'm just gonna give you some privileges here; hopefully it'll help you in working on this PR. |
|
@bors-servo delegate+ I messed up big time :) |
|
|
|
Looks like the font cache panic is gone, at least. |
|
|
|
Bah, back to the font cache failures :( |
|
@gsnedders Are you still working on this? I'm just triaging PRs and don't see any activity for the past month. |
|
@jdm Not actively. With the font cache panic still happening occasionally (despite my previous comment), we can't land it. So it's blocked on fixing that. |
|
@bors-servo: try |
|
@bors-servo try |
|
@bors-servo retry |
CSS test fonts This adds an up-to-date set of CSS tests fonts, specifically the subset that can be installed for all tests. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8374) <!-- Reviewable:end -->
|
|
|
Linux test-wpt output is https://gist.github.com/jdm/551a92fb9a5d68b2e5cf . |
|
I think the best course of action here is to log into a builder and try to catch one of the failures in a debugger (or rr?). |
|
Huh, these are all tests that contain a bunch of iframes. I guess we're creating a bunch of new threads with each font loaded, and that gets multiplied per iframe... |
|
I propose seeing what happens if https://github.com/gsnedders/servo/blob/03c7bc267bdcad1f073a5600433e435db22f8ce0/components/layout/layout_thread.rs#L341 is moved outside of the loop so it can be reused. My understanding is that IPC channels consume file descriptors, so this would be a significant reduction given how many fonts are requested by the CSS file. |
|
Superseded by #11311. |
gsnedders commentedNov 6, 2015
This adds an up-to-date set of CSS tests fonts, specifically the subset that can be installed for all tests.