Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename WebSocket::Send_Impl #8408

Merged
merged 1 commit into from Nov 8, 2015
Merged

rename WebSocket::Send_Impl #8408

merged 1 commit into from Nov 8, 2015

Conversation

@r-52
Copy link
Contributor

r-52 commented Nov 8, 2015

Previos: Send_Impl, now: send_impl.

Closes: #8345

Review on Reviewable
@r-52
rename WebSocket::Send_Impl
Loading status checks…
4f35941 
Previos: `Send_Impl`, now: `send_impl`.

Closes: #8345
@jdm
Copy link
Member

jdm commented Nov 8, 2015

@bors-servo: r+
Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2015

📌 Commit 4f35941 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2015

⌛ Testing commit 4f35941 with merge 9bcae9a...
bors-servo added a commit that referenced this pull request Nov 8, 2015
@bors-servo
Auto merge of #8408 - romankl:websocket-rename-impl, r=jdm
Loading status checks…
9bcae9a 
rename WebSocket::Send_Impl

Previos: `Send_Impl`, now: `send_impl`.

Closes: #8345

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8408)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2015

💔 Test failed - gonk
@r-52
Copy link
Contributor Author

r-52 commented Nov 8, 2015

Looks like the CI had a problem, somehow:

make[4]: execvp: ./host_jskwgen: Permission denied
make[4]: *** [/home/servo/buildbot/slave/gonk/build/target/arm-linux-androideabi/debug/build/mozjs_sys-e411d274df144795/out/js/src/jsautokw.h] Error 127
make[3]: *** [js/src/target] Error 2
@eefriedman eefriedman mentioned this pull request Nov 8, 2015
Closed
@eefriedman
Copy link
Contributor

eefriedman commented Nov 8, 2015

@bors-servo retry #8416
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2015

⚡ Previous build results for android, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only gonk, linux-rel...
@eefriedman
Copy link
Contributor

eefriedman commented Nov 8, 2015

(Also intermittent failure #8368.)
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 4f35941 into servo:master Nov 8, 2015
1 check passed
1 check passed
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Nov 8, 2015
Closed
@r-52 r-52 deleted the r-52:websocket-rename-impl branch Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@r-52 @jdm @bors-servo @eefriedman @SimonSapin @highfive
You can’t perform that action at this time.