Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement <hr> 'color' attribute #8419

Merged
merged 1 commit into from Nov 9, 2015
Merged

Implement <hr> 'color' attribute #8419

merged 1 commit into from Nov 9, 2015

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Nov 8, 2015

Review on Reviewable
@highfive
Copy link

highfive commented Nov 8, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@eefriedman
Copy link
Contributor

eefriedman commented Nov 8, 2015

Review status: 0 of 9 files reviewed at latest revision, 2 unresolved discussions.

components/script/dom/htmlhrelement.rs, line 51 [r1] (raw file):
impl HTMLHRLayoutHelpers for LayoutJS<HTMLHRElement> etc.

components/script/dom/htmlhrelement.rs, line 73 [r1] (raw file):
AttrValue::from_legacy_color().

Comments from the review on Reviewable.io
@eefriedman eefriedman self-assigned this Nov 8, 2015
@frewsxcv
Implement <hr> 'color' attribute
Loading status checks…
ee0800a
@frewsxcv frewsxcv force-pushed the frewsxcv:html-hr-element-color-attribute branch from b94f29f to ee0800a Nov 8, 2015
@frewsxcv
Copy link
Member Author

frewsxcv commented Nov 8, 2015

Comments have been addressed
@eefriedman
Copy link
Contributor

eefriedman commented Nov 8, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2015

📌 Commit ee0800a has been approved by eefriedman
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2015

⌛ Testing commit ee0800a with merge c8daf0b...
bors-servo added a commit that referenced this pull request Nov 8, 2015
@bors-servo
Auto merge of #8419 - frewsxcv:html-hr-element-color-attribute, r=eef…
c8daf0b 
…riedman

Implement <hr> 'color' attribute

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8419)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2015

💔 Test failed - gonk
@frewsxcv
Copy link
Member Author

frewsxcv commented Nov 8, 2015

@bors-servo retry

#8416
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2015

⌛ Testing commit ee0800a with merge 3780fb7...
bors-servo added a commit that referenced this pull request Nov 8, 2015
@bors-servo
Auto merge of #8419 - frewsxcv:html-hr-element-color-attribute, r=eef…
Loading status checks…
3780fb7 
…riedman

Implement <hr> 'color' attribute

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8419)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit ee0800a into servo:master Nov 9, 2015
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable Review in progress: 0 of 9 files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Nov 9, 2015
Merged
@frewsxcv frewsxcv deleted the frewsxcv:html-hr-element-color-attribute branch Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eefriedman eefriedman

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@frewsxcv @highfive @eefriedman @bors-servo
You can’t perform that action at this time.