refactor(htmlhrelement.rs): color setter now uses macro #8444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the function in #L44-47 to a macro usage
highfive
added
the
S-awaiting-review
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon. |
|
Thanks! @bors-servo r+ |
|
📌 Commit d0d2a64 has been approved by |
highfive
added
S-awaiting-merge
|
⌛ Testing commit d0d2a64 with merge 85dc3f9... |
bors-servo
pushed a commit
that referenced
this pull request
Nov 10, 2015
refactor(htmlhrelement.rs): color setter now uses macro Changed the function in #L44-47 to a macro usage. Fixes #8433. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8444) <!-- Reviewable:end -->
|
💔 Test failed - gonk |
highfive
added
S-tests-failed
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Nov 10, 2015
refactor(htmlhrelement.rs): color setter now uses macro Changed the function in #L44-47 to a macro usage. Fixes #8433. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8444) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
|
☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt |
|
@frewsxcv Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the function in #L44-47 to a macro usage. Fixes #8433.