Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) #8446

Merged
merged 1 commit into from Nov 27, 2015

Conversation

@Manishearth
Copy link
Member

Manishearth commented Nov 10, 2015

DO NOT r+ or try+ this

It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire.

Review on Reviewable

@Manishearth Manishearth force-pushed the rustup_20151110 branch from 65b09d0 to dcfbe7a Nov 10, 2015
@Manishearth Manishearth changed the title Rust upgrade Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) Nov 10, 2015
@Manishearth Manishearth force-pushed the rustup_20151110 branch 2 times, most recently from 48cd4ce to 788f314 Nov 10, 2015
@Manishearth
Copy link
Member Author

Manishearth commented Nov 10, 2015

Needs Rust master snapshot, cc @larsbergstrom

I believe this currently SIGILLs on libscript (only got to see the illegal instruction message once). Attempts to reproduce didn't work, since it kept crashing everything.

@Manishearth
Copy link
Member Author

Manishearth commented Nov 10, 2015

Unit test failure was due to rust-lang/rust@46068c9, removed unit test since it's no longer relevant

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Nov 12, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

Trying commit 7108e98 with merge fe640ee...

bors-servo added a commit that referenced this pull request Nov 12, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08)

DO NOT r+ or try+ this

It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

💔 Test failed - linux-rel

@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

The latest upstream changes (presumably #7844) made this pull request unmergeable. Please resolve the merge conflicts.

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Nov 12, 2015

@bors-servo retry

(failure was an unpatched build machine whose urllib was too old and mach saw it and exited)

@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

🔒 Merge conflict

@larsbergstrom larsbergstrom force-pushed the rustup_20151110 branch from 7108e98 to b94c1cd Nov 12, 2015
@larsbergstrom larsbergstrom force-pushed the rustup_20151110 branch from b94c1cd to 5620f6a Nov 12, 2015
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Nov 12, 2015

@bors-servo retry try

@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

Trying commit 5620f6a with merge a59bdb8...

bors-servo added a commit that referenced this pull request Nov 12, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08)

DO NOT r+ or try+ this

It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

💔 Test failed - linux-dev

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Nov 12, 2015

@bors-servo retry try

Looks like a reboot was required for urllib3 to get upgraded to a new version of openssl, as it was managed by the OS install instead of pip...

@bors-servo
Copy link
Contributor

bors-servo commented Nov 26, 2015

Trying commit d81cc68 with merge 24742e9...

bors-servo added a commit that referenced this pull request Nov 26, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08)

<s>DO NOT r+ or try+ this</s>

<s>It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. </s>

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2015

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Nov 27, 2015

@SimonSapin @Manishearth Nice work! :-)

@SimonSapin
Copy link
Member

SimonSapin commented Nov 27, 2015

@bors r=SimonSapin+Ms2ger+jdm+Manishearth


Reviewed 5 of 8 files at r12, 1 of 1 files at r13, 1 of 1 files at r15.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from the review on Reviewable.io

@SimonSapin
Copy link
Member

SimonSapin commented Nov 27, 2015

@bors-servo r=SimonSapin+Ms2ger+jdm+Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2015

📌 Commit d81cc68 has been approved by SimonSapin+Ms2ger+jdm+Manishearth

@SimonSapin SimonSapin closed this Nov 27, 2015
@SimonSapin
Copy link
Member

SimonSapin commented Nov 27, 2015

wat

@SimonSapin SimonSapin reopened this Nov 27, 2015
@SimonSapin
Copy link
Member

SimonSapin commented Nov 27, 2015

@bors-servo r=SimonSapin+Ms2ger+jdm+Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2015

📌 Commit d81cc68 has been approved by SimonSapin+Ms2ger+jdm+Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2015

The latest upstream changes (presumably #8689) made this pull request unmergeable. Please resolve the merge conflicts.

… and libc 0.2 and many other dependencies
@jdm jdm force-pushed the rustup_20151110 branch from d81cc68 to dc0e467 Nov 27, 2015
@jdm
Copy link
Member

jdm commented Nov 27, 2015

@bors-servo: r=SimonSapin+Ms2ger+jdm+Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2015

📌 Commit dc0e467 has been approved by SimonSapin+Ms2ger+jdm+Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2015

Testing commit dc0e467 with merge f13c72d...

bors-servo added a commit that referenced this pull request Nov 27, 2015
…Manishearth

Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08)

<s>DO NOT r+ or try+ this</s>

<s>It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. </s>

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2015

@bors-servo bors-servo merged commit dc0e467 into master Nov 27, 2015
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable Review in progress: 52 of 59 files reviewed, 2 unresolved discussions
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Manishearth Manishearth deleted the rustup_20151110 branch Nov 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.