Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer Atoms over strs for comparison #8453

Merged
merged 1 commit into from Nov 11, 2015
Merged

Prefer Atoms over strs for comparison #8453

merged 1 commit into from Nov 11, 2015

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Nov 10, 2015

Review on Reviewable

@jdm
Copy link
Member

jdm commented Nov 10, 2015

@bors-servo: r+
Good catch!

@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2015

📌 Commit 55477eb has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2015

Testing commit 55477eb with merge 076402f...

bors-servo added a commit that referenced this pull request Nov 10, 2015
Prefer Atoms over strs for comparison

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8453)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2015

💔 Test failed - gonk

@frewsxcv
Copy link
Member Author

frewsxcv commented Nov 11, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 11, 2015

Testing commit 55477eb with merge fd5540d...

bors-servo added a commit that referenced this pull request Nov 11, 2015
Prefer Atoms over strs for comparison

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8453)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 11, 2015

@bors-servo bors-servo merged commit 55477eb into servo:master Nov 11, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:atoms branch Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.