Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary 'node changed' notification #8476

Merged
merged 1 commit into from Nov 12, 2015

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Nov 11, 2015

This same notification already happens in CharacterData::SetData

Review on Reviewable

This same notification already happens in `CharacterData::SetData`
@nox nox self-assigned this Nov 11, 2015
@nox
Copy link
Member

nox commented Nov 11, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 11, 2015

📌 Commit 1789405 has been approved by nox

@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

Testing commit 1789405 with merge 1b20bc9...

bors-servo added a commit that referenced this pull request Nov 12, 2015
Remove unnecessary 'node changed' notification

This same notification already happens in `CharacterData::SetData`

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8476)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

💔 Test failed - gonk

@frewsxcv
Copy link
Member Author

frewsxcv commented Nov 12, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

Previous build results for android, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only gonk, linux-rel...

@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

@bors-servo bors-servo merged commit 1789405 into servo:master Nov 12, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:unnecessary-document-notification branch Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.