Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Default trait for DOMString #8479

Merged
merged 1 commit into from Nov 12, 2015
Merged

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Nov 12, 2015

Review on Reviewable

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 12, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

📌 Commit 00fa3b2 has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

Testing commit 00fa3b2 with merge 17aeeb2...

bors-servo added a commit that referenced this pull request Nov 12, 2015
Implement Default trait for DOMString

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8479)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

💔 Test failed - gonk

@frewsxcv
Copy link
Member Author

frewsxcv commented Nov 12, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

Testing commit 00fa3b2 with merge d32ce29...

@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

💔 Test failed - linux-rel

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Nov 12, 2015

@bors-servo retry
(I messed up the build machines)

@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

Testing commit 00fa3b2 with merge 1baab85...

bors-servo added a commit that referenced this pull request Nov 12, 2015
Implement Default trait for DOMString

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8479)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

💔 Test failed - android

@eefriedman
Copy link
Contributor

eefriedman commented Nov 12, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

Testing commit 00fa3b2 with merge 1720595...

bors-servo added a commit that referenced this pull request Nov 12, 2015
Implement Default trait for DOMString

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8479)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

@bors-servo bors-servo merged commit 00fa3b2 into servo:master Nov 12, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:domstring-default branch Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.