Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script: Make timer events e10s-safe. #8492

Merged
merged 1 commit into from
Nov 13, 2015
Merged

script: Make timer events e10s-safe. #8492

merged 1 commit into from
Nov 13, 2015

Conversation

jdm
Copy link
Member

@jdm jdm commented Nov 12, 2015

Closes #8235.

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 12, 2015
@jdm
Copy link
Member Author

jdm commented Nov 12, 2015

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 054c109 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 12, 2015
@jdm
Copy link
Member Author

jdm commented Nov 12, 2015

Rebase of #8237.

@bors-servo
Copy link
Contributor

⌛ Testing commit 054c109 with merge a7fa2f0...

bors-servo pushed a commit that referenced this pull request Nov 12, 2015
Auto merge of #8492 - jdm:e10s-timer-events, r=jdm
a7fa2f0 
script: Make timer events e10s-safe.

Closes #8235.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8492)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 12, 2015
@jdm
Copy link
Member Author

jdm commented Nov 12, 2015

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 054c109 with merge 3a36ee3...

bors-servo pushed a commit that referenced this pull request Nov 12, 2015
Auto merge of #8492 - jdm:e10s-timer-events, r=jdm
3a36ee3 
script: Make timer events e10s-safe.

Closes #8235.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8492)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 12, 2015
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 12, 2015
@eefriedman
Copy link
Contributor 

/home/servo/buildbot/slave/linux-rel/build/components/script/dom/window.rs:57:21: 57:32 error: unresolved import `script_traits::MsgDuration`. There is no `MsgDuration` in `script_traits` [E0432]
/home/servo/buildbot/slave/linux-rel/build/components/script/dom/window.rs:57 use script_traits::{MsgDuration, TimerEvent, TimerEventId, TimerEventRequest, TimerSource};
                                                                                                  ^~~~~~~~~~~

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 12, 2015
@jdm
Copy link
Member Author

jdm commented Nov 12, 2015

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 1dc0d61 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 12, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit 1dc0d61 with merge 9eaa8e7...

bors-servo pushed a commit that referenced this pull request Nov 12, 2015
Auto merge of #8492 - jdm:e10s-timer-events, r=jdm
9eaa8e7 
script: Make timer events e10s-safe.

Closes #8235.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8492)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit 1dc0d61 into servo:master Nov 13, 2015
@jdm jdm mentioned this pull request Nov 13, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jdm @bors-servo @eefriedman @highfive @pcwalton