Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: Make timer events e10s-safe. #8492

Merged
merged 1 commit into from Nov 13, 2015
Merged

script: Make timer events e10s-safe. #8492

merged 1 commit into from Nov 13, 2015

Conversation

@jdm
Copy link
Member

jdm commented Nov 12, 2015

Closes #8235.

Review on Reviewable
@jdm
Copy link
Member Author

jdm commented Nov 12, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

📌 Commit 054c109 has been approved by jdm
@jdm
Copy link
Member Author

jdm commented Nov 12, 2015

Rebase of #8237.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

⌛ Testing commit 054c109 with merge a7fa2f0...
bors-servo added a commit that referenced this pull request Nov 12, 2015
@bors-servo
Auto merge of #8492 - jdm:e10s-timer-events, r=jdm
a7fa2f0 
script: Make timer events e10s-safe.

Closes #8235.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8492)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member Author

jdm commented Nov 12, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

⌛ Testing commit 054c109 with merge 3a36ee3...
bors-servo added a commit that referenced this pull request Nov 12, 2015
@bors-servo
Auto merge of #8492 - jdm:e10s-timer-events, r=jdm
3a36ee3 
script: Make timer events e10s-safe.

Closes #8235.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8492)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

💔 Test failed - linux-rel
@eefriedman
Copy link
Contributor

eefriedman commented Nov 12, 2015 

/home/servo/buildbot/slave/linux-rel/build/components/script/dom/window.rs:57:21: 57:32 error: unresolved import `script_traits::MsgDuration`. There is no `MsgDuration` in `script_traits` [E0432]
/home/servo/buildbot/slave/linux-rel/build/components/script/dom/window.rs:57 use script_traits::{MsgDuration, TimerEvent, TimerEventId, TimerEventRequest, TimerSource};
                                                                                                  ^~~~~~~~~~~
@pcwalton @jdm
script: Make timer events e10s-safe.
Loading status checks…
1dc0d61 
Closes #8235.
@jdm jdm force-pushed the jdm:e10s-timer-events branch from 054c109 to 1dc0d61 Nov 12, 2015
@jdm
Copy link
Member Author

jdm commented Nov 12, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

📌 Commit 1dc0d61 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2015

⌛ Testing commit 1dc0d61 with merge 9eaa8e7...
bors-servo added a commit that referenced this pull request Nov 12, 2015
@bors-servo
Auto merge of #8492 - jdm:e10s-timer-events, r=jdm
Loading status checks…
9eaa8e7 
script: Make timer events e10s-safe.

Closes #8235.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8492)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 1dc0d61 into servo:master Nov 13, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Nov 13, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @bors-servo @eefriedman @highfive @pcwalton
You can’t perform that action at this time.