Fix #8443 #8496

notriddle · 2015-11-12T19:01:39Z

When there are viewport constraints, use the new window size to compute the viewport instead of the old one.

eefriedman · 2015-11-13T01:37:28Z

Do you have to do something to make the test harness ignore meta_viewport_resize_iframe.html? Or am I getting things mixed up?

notriddle · 2015-11-13T02:25:44Z

It's not in the manifest. Is it being automatically added? If so, we can
convert it into a data URL.

On Thu, Nov 12, 2015, 18:37 eefriedman notifications@github.com wrote:

Do you have to do something to make the test harness ignore
meta_viewport_resize_iframe.html? Or am I getting things mixed up?

—
Reply to this email directly or view it on GitHub
#8496 (comment).

eefriedman · 2015-11-13T02:29:40Z

You can see if the harness thinks the current manifest is correct by running something like ./mach test-wpt --update-manifest.

jdm · 2015-11-13T04:18:52Z

My understanding is that only files containing <link rel=match href=...> and <script src=/resources/testharness.js> get added to the manifest automatically.

eefriedman · 2015-11-13T04:43:52Z

Oh, I didn't realize it was quite that smart. Okay, thanks.

@bors-servo r+

bors-servo · 2015-11-13T04:43:52Z

📌 Commit c770908 has been approved by eefriedman

bors-servo · 2015-11-13T04:43:54Z

⌛ Testing commit c770908 with merge 3d50c03...


        Auto merge of #8496 - notriddle:master, r=eefriedman

Fix #8443 When there are viewport constraints, use the new window size to compute the viewport instead of the old one.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8496)

bors-servo · 2015-11-13T05:13:04Z

💔 Test failed - mac-rel-wpt

Ms2ger · 2015-11-13T10:47:29Z

Review status: 0 of 4 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

^{tests/wpt/mozilla/tests/css/meta_viewport_resize.html, line 10 [r2] (raw file):}
This would be better as an async_test.

^{tests/wpt/mozilla/tests/css/meta_viewport_resize.html, line 18 [r2] (raw file):}
Remove the console.log call.

^{tests/wpt/mozilla/tests/css/meta_viewport_resize.html, line 22 [r2] (raw file):}
What's this timeout based on?

Comments from the review on Reviewable.io

notriddle · 2015-11-13T14:20:30Z

^{tests/wpt/mozilla/tests/css/meta_viewport_resize.html, line 22 [r2] (raw file):}
The number is pretty much arbitrary; the point is to wait until reflow is done.

requestAnimationFrame works when I tried it on by box, so let's see if the Mac agrees.

Comments from the review on Reviewable.io

notriddle · 2015-11-14T17:50:48Z

@bors-servo try

jdm · 2015-11-14T22:10:47Z

@notriddle Please make a PR to servo/saltfs to add yourself to the list of users with try access.

jdm · 2015-11-14T22:11:05Z

@bors-servo: try

bors-servo · 2015-11-14T22:11:08Z

⌛ Trying commit 94463a7 with merge 086f225...


        Auto merge of #8496 - notriddle:master, r=<try>

Fix #8443 When there are viewport constraints, use the new window size to compute the viewport instead of the old one.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8496)

bors-servo · 2015-11-14T22:54:09Z

💔 Test failed - mac-rel-wpt

bors-servo · 2016-03-29T16:44:03Z

📌 Commit 18dfef0 has been approved by notriddle

jdm · 2016-03-29T17:18:49Z

@bors-servo: r-

jdm · 2016-03-29T17:19:15Z

There's a trailing space in MANIFEST.json.

@SimonSapin


        Add @SimonSapin's test case for #8443

notriddle · 2016-03-29T17:23:02Z

Fixed that 🤦

@bors-servo r=jdm

bors-servo · 2016-03-29T17:23:03Z

📌 Commit ef571ef has been approved by jdm

bors-servo · 2016-03-29T18:52:47Z

⌛ Testing commit ef571ef with merge d0b2089...


        Auto merge of #8496 - notriddle:master, r=jdm

Fix #8443 When there are viewport constraints, use the new window size to compute the viewport instead of the old one.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8496)

bors-servo · 2016-03-29T20:40:35Z

💔 Test failed - status-appveyor

notriddle · 2016-03-29T20:42:00Z

@bors-servo retry

#10251

bors-servo · 2016-03-29T21:33:04Z

💣 Failed to start rebuilding: Unknown error

bors-servo · 2016-03-29T21:33:06Z

⌛ Testing commit ef571ef with merge 210a243...


        Auto merge of #8496 - notriddle:master, r=jdm

Fix #8443 When there are viewport constraints, use the new window size to compute the viewport instead of the old one.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8496)

bors-servo · 2016-03-30T00:10:59Z

☀️ Test successful - android, arm32, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor

highfive added the S-awaiting-review label Nov 12, 2015

eefriedman self-assigned this Nov 13, 2015

highfive removed the S-awaiting-review label Nov 13, 2015

highfive added the S-awaiting-merge label Nov 13, 2015

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 13, 2015

highfive added S-awaiting-review and removed S-tests-failed labels Nov 13, 2015

eefriedman assigned Ms2ger and unassigned eefriedman Nov 13, 2015

notriddle mentioned this pull request Nov 14, 2015

Give myself permission to `@bors-servo try`. servo/saltfs#162

Merged

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 14, 2015

highfive added S-awaiting-merge and removed S-awaiting-review labels Mar 29, 2016

jdm added S-fails-tidy S-needs-code-changes and removed S-awaiting-merge S-blocked-on-external labels Mar 29, 2016

Add @SimonSapin's test case for #8443

Loading status checks…

ef571ef

highfive added S-awaiting-review and removed S-needs-code-changes labels Mar 29, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Mar 29, 2016

jdm removed the S-fails-tidy label Mar 29, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Mar 29, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Mar 29, 2016

bors-servo merged commit ef571ef into servo:master Mar 30, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

servo / servo

Fix #8443 #8496

Fix #8443 #8496

notriddle commented Nov 12, 2015

eefriedman commented Nov 13, 2015

notriddle commented Nov 13, 2015

eefriedman commented Nov 13, 2015

jdm commented Nov 13, 2015

eefriedman commented Nov 13, 2015

bors-servo commented Nov 13, 2015

bors-servo commented Nov 13, 2015

bors-servo commented Nov 13, 2015

Ms2ger commented Nov 13, 2015

notriddle commented Nov 13, 2015

notriddle commented Nov 14, 2015

jdm commented Nov 14, 2015

jdm commented Nov 14, 2015

bors-servo commented Nov 14, 2015

bors-servo commented Nov 14, 2015

bors-servo commented Mar 29, 2016

jdm commented Mar 29, 2016

jdm commented Mar 29, 2016

notriddle commented Mar 29, 2016

bors-servo commented Mar 29, 2016

bors-servo commented Mar 29, 2016

bors-servo commented Mar 29, 2016

notriddle commented Mar 29, 2016

bors-servo commented Mar 29, 2016

bors-servo commented Mar 29, 2016

bors-servo commented Mar 30, 2016

servo / servo

Join GitHub today

Fix #8443 #8496

Fix #8443 #8496

Conversation

notriddle commented Nov 12, 2015

eefriedman commented Nov 13, 2015

notriddle commented Nov 13, 2015

eefriedman commented Nov 13, 2015

jdm commented Nov 13, 2015

eefriedman commented Nov 13, 2015

bors-servo commented Nov 13, 2015

bors-servo commented Nov 13, 2015

bors-servo commented Nov 13, 2015

Ms2ger commented Nov 13, 2015

notriddle commented Nov 13, 2015

notriddle commented Nov 14, 2015

jdm commented Nov 14, 2015

jdm commented Nov 14, 2015

bors-servo commented Nov 14, 2015

bors-servo commented Nov 14, 2015

bors-servo commented Mar 29, 2016

jdm commented Mar 29, 2016

jdm commented Mar 29, 2016

notriddle commented Mar 29, 2016

bors-servo commented Mar 29, 2016

bors-servo commented Mar 29, 2016

bors-servo commented Mar 29, 2016

notriddle commented Mar 29, 2016

bors-servo commented Mar 29, 2016

bors-servo commented Mar 29, 2016

bors-servo commented Mar 30, 2016