Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer atoms over strs for string comparisons #8504

Merged
merged 2 commits into from Nov 13, 2015
Merged

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Nov 13, 2015

Review on Reviewable

@jdm
Copy link
Member

jdm commented Nov 13, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2015

📌 Commit 7b8d5bb has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2015

Testing commit 7b8d5bb with merge 7de6d42...

bors-servo added a commit that referenced this pull request Nov 13, 2015
Prefer atoms over strs for string comparisons

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8504)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2015

💔 Test failed - gonk

@frewsxcv
Copy link
Member Author

frewsxcv commented Nov 13, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2015

Testing commit 7b8d5bb with merge 1763a37...

bors-servo added a commit that referenced this pull request Nov 13, 2015
Prefer atoms over strs for string comparisons

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8504)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2015

💔 Test failed - android

@frewsxcv
Copy link
Member Author

frewsxcv commented Nov 13, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2015

Previous build results for gonk, mac-dev-ref-unit are reusable. Rebuilding only android, linux-dev, linux-rel, mac-rel-css, mac-rel-wpt...

@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2015

@bors-servo bors-servo merged commit 7b8d5bb into servo:master Nov 13, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:more-atoms branch Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.