Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'bgcolor' IDL attribute for 'HTMLTableCellElement' #8505

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Nov 13, 2015

Review on Reviewable

@Manishearth
Copy link
Member

Manishearth commented Nov 13, 2015

Does this actually have an effect in the displayed element?

Kinda wary of adding IDL attributes which don't perform atleast a subset of their functionality.

r=me if it has the expected effect

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 13, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2015

📌 Commit 765ade6 has been approved by Ms2ger

@Ms2ger Ms2ger self-assigned this Nov 13, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2015

Testing commit 765ade6 with merge f078f8f...

bors-servo added a commit that referenced this pull request Nov 13, 2015
…tribute, r=Ms2ger

Implement 'bgcolor' IDL attribute for 'HTMLTableCellElement'

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8505)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2015

💔 Test failed - linux-rel

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 13, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2015

Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...

@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2015

@bors-servo bors-servo merged commit 765ade6 into servo:master Nov 13, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:html-table-cell-element-bgcolor-idl-attribute branch Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.