Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen for cancellation message during loads and redirects... #8523

Merged
merged 1 commit into from Nov 14, 2015
Merged

Listen for cancellation message during loads and redirects... #8523

merged 1 commit into from Nov 14, 2015

Conversation

@wafflespeanut
Copy link
Member

wafflespeanut commented Nov 13, 2015

fixes #8495

Review on Reviewable
@wafflespeanut
Copy link
Member Author

wafflespeanut commented Nov 13, 2015

@jdm Now, we're checking for the cancel listener's status at the start of every load/redirect loops. r?
@wafflespeanut
Testing cancellation during redirects
Loading status checks…
afb9b07
@wafflespeanut wafflespeanut force-pushed the wafflespeanut:redirects branch from 4a8ec05 to afb9b07 Nov 14, 2015
@jdm
Copy link
Member

jdm commented Nov 14, 2015

@bors-servo: r+
Looks great!
@bors-servo
Copy link
Contributor

bors-servo commented Nov 14, 2015

📌 Commit afb9b07 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 14, 2015

⌛ Testing commit afb9b07 with merge bda4617...
bors-servo added a commit that referenced this pull request Nov 14, 2015
@bors-servo
Auto merge of #8523 - Wafflespeanut:redirects, r=jdm
Loading status checks…
bda4617 
Listen for cancellation message during loads and redirects...

fixes #8495

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8523)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 14, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit afb9b07 into servo:master Nov 14, 2015
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable Review in progress: 0 of 3 files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Nov 14, 2015
Closed
@wafflespeanut wafflespeanut deleted the wafflespeanut:redirects branch Nov 14, 2015
@wafflespeanut
Copy link
Member Author

wafflespeanut commented Nov 14, 2015

@jdm Thanks!
@jdm jdm mentioned this pull request Jan 27, 2017
Closed
@jdm jdm mentioned this pull request Oct 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Allow cancelling an HTTP request earlier than the final body
4 participants
@wafflespeanut @jdm @bors-servo @highfive
You can’t perform that action at this time.