Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update our implementation of DOMTokenList #8525

Closed
wants to merge 2 commits into from
Closed

Update our implementation of DOMTokenList #8525

wants to merge 2 commits into from

Conversation

@ngsankha
Copy link
Contributor

ngsankha commented Nov 14, 2015

#8511

Review on Reviewable
ngsankha added 2 commits Nov 14, 2015
@ngsankha
Add DomTokenList.replace and tests. Fixes #8511
20a6557
@ngsankha
empty string when no classes are set
Loading status checks…
3c45526
@nox nox self-assigned this Nov 16, 2015
@nox
Copy link
Member

nox commented Nov 16, 2015

Thanks for your contribution. You don't seem to have fixed the serialisation, am I wrong?

-S-awaiting-review +S-needs-code-changes

Reviewed 3 of 3 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

components/script/dom/domtokenlist.rs, line 142 [r1] (raw file):
You should use attribute() and work on its AttrValue, instead of using get_tokenlist_attribute() and set_atomic_tokenlist_attribute().

I don't see the code for the validation steps in step 3.

Comments from the review on Reviewable.io
@nox
Copy link
Member

nox commented Dec 13, 2015

@sankha93 Ping?
@ngsankha
Copy link
Contributor Author

ngsankha commented Dec 14, 2015

@nox Sorry, I was a bit busy. Will get back on this today.
@nox
Copy link
Member

nox commented Dec 14, 2015

No problem, just triaging. :)
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2015

☔ The latest upstream changes (presumably #8959) made this pull request unmergeable. Please resolve the merge conflicts.
@nox
Copy link
Member

nox commented Dec 30, 2015

@sankha93 Want me to take it over? Not hurried, just checking.
@nox nox mentioned this pull request Jan 17, 2016
Merged
@nox
Copy link
Member

nox commented Jan 17, 2016

See #9353.
@nox nox closed this Jan 17, 2016
bors-servo added a commit that referenced this pull request Mar 25, 2016
@bors-servo
Auto merge of #9353 - nox:domtokenlist-replace, r=asajeffrey
Loading status checks…
59ba00e 
Implement and test DOMTokenList.replace (fixes #8511)

Thanks to @sankha93 for the original work in #8525.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9353)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-needs-code-changes S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@ngsankha @nox @bors-servo @highfive
You can’t perform that action at this time.