Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace Atom::from_slice("sizes") with atom!("sizes") #8527
Conversation
|
Thanks a lot! One small nit below. -S-awaiting-review +S-needs-code-changes Reviewed 3 of 3 files at r1, 1 of 1 files at r2. components/script/dom/htmllinkelement.rs, line 133 [r2] (raw file): Comments from the review on Reviewable.io |
|
Thanks - I've updated the PR Comments from the review on Reviewable.io |
|
Reviewed 1 of 1 files at r3. components/script/dom/htmllinkelement.rs, line 129 [r3] (raw file): Comments from the review on Reviewable.io |
|
components/script/dom/htmllinkelement.rs, line 129 [r3] (raw file): Comments from the review on Reviewable.io |
|
Thanks again! @bors-servo r+ Reviewed 1 of 1 files at r4. Comments from the review on Reviewable.io |
|
|
Replace Atom::from_slice("sizes") with atom!("sizes")
This PR replaces all occurrences of Atom::from_slice("sizes") with atom!("sizes"). It also updates string_cache to v0.1.17 from 0.1.16.
Right now I've split the crate update and the replace in different commits - should I squash them?
Fixes #8488.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8527)
<!-- Reviewable:end -->
|
|
r-52 commentedNov 14, 2015
This PR replaces all occurrences of Atom::from_slice("sizes") with atom!("sizes"). It also updates string_cache to v0.1.17 from 0.1.16.
Right now I've split the crate update and the replace in different commits - should I squash them?
Fixes #8488.