Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Atom::from_slice("sizes") with atom!("sizes") #8527

Merged
merged 2 commits into from Nov 15, 2015

Conversation

@r-52
Copy link
Contributor

r-52 commented Nov 14, 2015

This PR replaces all occurrences of Atom::from_slice("sizes") with atom!("sizes"). It also updates string_cache to v0.1.17 from 0.1.16.

Right now I've split the crate update and the replace in different commits - should I squash them?

Fixes #8488.

Review on Reviewable

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 14, 2015

Thanks a lot! One small nit below.

-S-awaiting-review +S-needs-code-changes


Reviewed 3 of 3 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


components/script/dom/htmllinkelement.rs, line 133 [r2] (raw file):
This could just be &atom!("sizes") now.


Comments from the review on Reviewable.io

@r-52
Copy link
Contributor Author

r-52 commented Nov 14, 2015

Thanks - I've updated the PR


Comments from the review on Reviewable.io

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 14, 2015

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


components/script/dom/htmllinkelement.rs, line 129 [r3] (raw file):
Sorry, I didn't notice this earlier. We can replace this use by its definition too.


Comments from the review on Reviewable.io

@r-52
Copy link
Contributor Author

r-52 commented Nov 14, 2015

components/script/dom/htmllinkelement.rs, line 129 [r3] (raw file):
No problem - thank you for the review!


Comments from the review on Reviewable.io

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 15, 2015

Thanks again!

@bors-servo r+


Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2015

📌 Commit 0813ee7 has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2015

Testing commit 0813ee7 with merge c722e0e...

bors-servo added a commit that referenced this pull request Nov 15, 2015
Replace Atom::from_slice("sizes") with atom!("sizes")

This PR replaces all occurrences of Atom::from_slice("sizes") with atom!("sizes"). It also updates string_cache to v0.1.17 from 0.1.16.

Right now I've split the crate update and the replace in different commits - should I squash them?

Fixes #8488.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8527)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2015

@bors-servo bors-servo merged commit 0813ee7 into servo:master Nov 15, 2015
3 checks passed
3 checks passed
code-review/reviewable Review complete: all files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.