Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused lifetime parameters from LayoutTask methods. #8529

Merged
merged 1 commit into from Nov 14, 2015
Merged

Remove unused lifetime parameters from LayoutTask methods. #8529

merged 1 commit into from Nov 14, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 14, 2015

Review on Reviewable
@Ms2ger
Remove unused lifetime parameters from LayoutTask methods.
Loading status checks…
15245b3
@highfive
Copy link

highfive commented Nov 14, 2015

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
@eefriedman
Copy link
Contributor

eefriedman commented Nov 14, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 14, 2015

📌 Commit 15245b3 has been approved by eefriedman
@bors-servo
Copy link
Contributor

bors-servo commented Nov 14, 2015

⌛ Testing commit 15245b3 with merge 33c97b2...
bors-servo added a commit that referenced this pull request Nov 14, 2015
@bors-servo
Auto merge of #8529 - Ms2ger:unused-lifetime, r=eefriedman
Loading status checks…
33c97b2 
Remove unused lifetime parameters from LayoutTask methods.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8529)
<!-- Reviewable:end -->
@eefriedman eefriedman self-assigned this Nov 14, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Nov 14, 2015

💔 Test failed - linux-rel
@eefriedman
Copy link
Contributor

eefriedman commented Nov 14, 2015

@bors-servo retry #8487
@bors-servo
Copy link
Contributor

bors-servo commented Nov 14, 2015

⚡ Previous build results for android, gonk, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-dev, linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 14, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 15245b3 into servo:master Nov 14, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:unused-lifetime branch Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eefriedman eefriedman

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @eefriedman @bors-servo @SimonSapin
You can’t perform that action at this time.